[ http://issues.apache.org/jira/browse/POOL-93?page=comments#action_12452542 ] Sandy McArthur commented on POOL-93: ------------------------------------
First look at the patch looks good. Any reason not to replace direct access of _testOnReturn with calls to getTestOnReturn() ? This would be thread-safe and allow newer HotSpot versions do the analysis to determine if the synchronization of getTestOnReturn() is really needed. The problem with volatile is we still need to support Java 1.4 and it wasn't until 1.5 JVMs that volatile was handled correctly in all JVMs. > Reduce contention by making borrow & return more independent from each other > ---------------------------------------------------------------------------- > > Key: POOL-93 > URL: http://issues.apache.org/jira/browse/POOL-93 > Project: Commons Pool > Issue Type: Improvement > Affects Versions: Nightly Builds > Reporter: Holger Hoffstätte > Attachments: GKOP-relaxedSyncOnReturn.patch, > relaxedReturnObjectBenchmark.txt > > > Currently borrow & return are completely blocked from each other, while at > least the factory-based validation & destruction can be handled > independently. A few simple changes narrow the synchronization blocks yet > retain overall correctness. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
