[ http://issues.apache.org/jira/browse/DIGESTER-110?page=comments#action_12452599 ] Rahul Akolkar commented on DIGESTER-110: ----------------------------------------
Looks good to me (didn't try applying since I'm on limited dev time this weekend). digester trunk is open for commits, please go ahead. > Create APIs that accept URL values directly, instead of only Strings to be > converted to URLs > -------------------------------------------------------------------------------------------- > > Key: DIGESTER-110 > URL: http://issues.apache.org/jira/browse/DIGESTER-110 > Project: Commons Digester > Issue Type: Improvement > Affects Versions: 1.6 Final > Reporter: Craig McClanahan > Attachments: diffs.txt, URLTestCase.java > > > Currently, Digester provides a number of convenience methods such as parse() > that access the XML content to be parsed in a variety of ways. The most > commonly used ones are probably those that take the String form of a URL. > In a web application environment, it is common for applications or frameworks > to call ServletContext.getResource() to acquire the URL of a web application > resource to be parsed. With the current Digester implementation, this must > be converted to a String (using toString() or toExternalForm()), and then -- > internal to Digester -- converted back to a URL. For this to work > successfully, there must be a lossless conversion of the URL returned by > ServletContext.getResource(), to a String, and then back to a URL. While > this process succeeds on most popular servlet containers today, it is *not* > guaranteed to work ... it is entirely reasonable for a servlet container to > embed customized information in the URL implementation that is returned by > ServletContext.getResource(), and this information would be lost in the > conversions described above. > To be safe, Digester should provide alternative public APIs that accept URLs > directly, in addition to the current APIs maintained for backwards > compatibility. At a minimum, that would mean adding the following public > method signatures to Digester itself: > * public Object parse(java.net.URL url) > * public void register(java.lang.String publicId, java.net.URL entityURL) > plus any other scenarios where strings are used as URLs. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]