[ http://issues.apache.org/jira/browse/NET-146?page=comments#action_12459765 ] Daniel Savarese commented on NET-146: -------------------------------------
After reviewing the old bugzilla issue, I think the problem is that the telnet protocol implementation for the control connection always sits in a read waiting for events (and that read is timing out). If that read were started only after the data transfer completed, it wouldn't time out. If that's the case, then, yes, that would be a bug and that's why disabling the reader thread works around the problem. Rory's changes for 2.0 won't have the problem because it doesn't use TelnetClient. > wrong handling of timeouts > -------------------------- > > Key: NET-146 > URL: http://issues.apache.org/jira/browse/NET-146 > Project: Commons Net > Issue Type: Bug > Affects Versions: 1.4 Final > Environment: linux 2.6, java 1.5.0_08 (but most probably any > environment) > Reporter: Koloom > > If you set a timeout on the control connection and then make a data transfer > (upload, download) which takes longer than that timeout, the client throws > the following exception. It seems like the client tries to read something > from the control connection while the data transfer is in progress and then > it just throws an exception. It makes the application think that the transfer > failed even though it succeeded. > aused by: java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at java.net.SocketInputStream.read(SocketInputStream.java:129) > at java.io.BufferedInputStream.fill(BufferedInputStream.java:218) > at java.io.BufferedInputStream.read(BufferedInputStream.java:235) > at java.io.FilterInputStream.read(FilterInputStream.java:66) > at java.io.PushbackInputStream.read(PushbackInputStream.java:120) > at > org.apache.commons.net.io.FromNetASCIIInputStream.__read(FromNetASCIIInputStream.java:75) > at > org.apache.commons.net.io.FromNetASCIIInputStream.read(FromNetASCIIInputStream.java:170) > at java.io.BufferedInputStream.fill(BufferedInputStream.java:218) > at java.io.BufferedInputStream.read(BufferedInputStream.java:235) > at > org.apache.commons.net.telnet.TelnetInputStream.__read(TelnetInputStream.java:114) > at > org.apache.commons.net.telnet.TelnetInputStream.run(TelnetInputStream.java:535) > at java.lang.Thread.run(Thread.java:595) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
