Hi Rory, Voting threads are usually +72 hours and we should only deviate from that if theres a good reason IMO.
I have the following comments on the release: 1) ASF Source Header and Copyright Notice Policy The release needs to conform to the new ASF policy. Henri used a script to update most of commons, but I think this got missed because you're releasing from a branch? http://www.apache.org/legal/src-headers.html (N.B. As well as source file headers the NOTICE.txt also needs updating for this). 2) Tagging the Release Candidate Can you tag the release candidate in subversion - svn tags are cheap and it clearly defines where the release has been cut from - more important IMO if your doing it from a branch. Also when preparing the RC its a good idea to check out a fresh copy from the tag - which ensures that any local crud doesn't get accidentally included. 3) Both jar files don't include the LICENSE file 4) commons-net-2.0.0-SNAPSHOT.jar manifest is missing the following elements: Extension-Name Specification-Title Specification-Vendor Specification-Version Implementation-Title Implementation-Vendor Implementation-Version Implementation-Vendor-Id 5) commons-net-ftp-2.0.0-SNAPSHOT.jar manifest is missing the following elements: Implementation-Title Implementation-Vendor Implementation-Version Implementation-Vendor-Id 6) The binary distro doesn't include release notes - most components include a RELEASE-NOTES.txt file, even if it only refers to maven's changes-report 7) The binary distro doesn't include any docs - we usually at least include the javadoc. 8) The pom.xml doesn't inherit from commons-parent 9) The source distro looks like its missing a few files that are in the JDK_1_5_BRANCH (assembly-bin.xml, assembly-src.xml, project.properties - which also should have license headers) 10) The following source files are missing headers: src\main\java\examples\NetClient.java src\main\java\examples\nntp\NNTPUtils.java src\main\java\org\apache\commons\net\nntp\Article.java src\test\java\org\apache\commons\net\ftp\parser\AllTests.java src\test\java\org\apache\commons\net\ntp\TimeStampTest.java src\test\java\org\apache\commons\net\time\TimeTCPClientTest.java src\test\java\org\apache\commons\net\time\TimeTestSimpleServer.java 11) On the site: - mail archives are pointing to "eyebrowse" (this would be fixed if inherited from commons-parent pom) - project summary has invalid url for commons net home page - source repository page points to the "trunk" - but looks to me like its built from the branch - download page just points to the general Jakarta downloads - rather than the "net" specific one: http://jakarta.apache.org/site/downloads/downloads_commons-net.cgi Since this version has move to JDK 1.5 there isn't binary compatibility with previous releases, but besides moving to JDK 1.5 is it otherwise compatible with previous releases? If this is now the main focus of development - shouldn't a branch be created for whats in the current trunk and this JDK 1.5 branch merged into the trunk - or are there still people actively developing the pre-jdk1.5 version? Just as a note, there are quite a few docs on releases that help avoid some of the pitfalls and are worth using for both a RC and actually cutting the release: http://jakarta.apache.org/commons/releases/index.html http://wiki.apache.org/jakarta-commons/ReleaseChecking http://wiki.apache.org/jakarta-commons/ReleaseShoppingList Niall On 12/20/06, Rory Winston <[EMAIL PROTECTED]> wrote:
Hi guys I know I have gone through the voting process a while back, but there have been many more changed added in to the 2.0 branch of [net] since then. I also remembered that the concept of a JDK 5.0+ only release got a somewhat lukewarm reception at the time, but sparked a lot of constructive dialogue on the topic. So....if I leave this vote thread open for 24 hours or so, I can attempt to release at the end of the week if it passes. The changes are here: http://people.apache.org/~rwinston/commons-net-2.0/site/changes-report.html#2.0 Artefacts are available here: http://people.apache.org/~rwinston/commons-net-2.0/ So please, give it your relevant +1, +0, -0, -1.
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
