[
https://issues.apache.org/jira/browse/LANG-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467984
]
Henri Yandell commented on LANG-69:
-----------------------------------
I think the first step is to drop the register in appendStart, then in
appendInternal the logic should be:
---
if registered, write identity and return.
register.
switch statement of different ones.
finally-unregister.
---
This seems to improve things. ArrayUtils passes and while there are still
failures in ToStringBuilder, there are no longer stack overflows. Just
incorrect values. As I said.. 'seems to' :) I'll take anything as a positive
sign.
> [lang] ToStringBuilder throws StackOverflowError when an Object cycle exists
> ----------------------------------------------------------------------------
>
> Key: LANG-69
> URL: https://issues.apache.org/jira/browse/LANG-69
> Project: Commons Lang
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: Operating System: other
> Platform: Other
> Reporter: Maarten Coene
> Assigned To: Gary Gregory
> Fix For: 2.3
>
> Attachments: 15938.patch, 36061.patch, LANG-69-refactor.patch,
> ReflectionToStringBuilder.java.patch, ToStringBuilderTest.java.patch,
> ToStringStyle.java.patch
>
>
> Hi,
> The ToStringBuilder throws a StackOverflowError if you have a cycle in the
> object graph. For instance, the following toString() method will cause a
> StackOverflowError:
> public class ObjectCycle {
> Object obj;
>
> public String toString() {
> return new ToStringBuilder(this).append(obj).toString();
> }
> }
> public void testObjectCycle() {
> ObjectCycle a = new ObjectCycle();
> ObjectCycle b = new ObjectCycle();
> a.obj = b;
> b.obj = a;
> a.toString(); // ouch: StackOverflowError
> }
> I'll submit some patches that fixes this problem...
> regards,
> Maarten
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
