[ 
https://issues.apache.org/jira/browse/EMAIL-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ben Speakmon updated EMAIL-54:
------------------------------

    Attachment: charset-support.patch

Attaching a patch and updated test cases for better charset support.

* adds addTo(), addCc(), addReplyTo(), addBcc() overloads which take parameters 
(email, name, charset) and creates InternetAddresses that get encoded using the 
specified charset. This fixes EMAIL-25.

* All charset names are now passed to java.nio.charset.Charset.forName(), which 
confirms that the requested charset is available in the current JVM and returns 
the canonical name for it. Invalid charset names will be detected and the 
proper exception thrown. This fixes EMAIL-14.

* Finally, delegating charset handling to the JVM means we don't need a 
separate Charset class or create a need to maintain some kind of registry of 
correct names. A couple of comments on the charset issues request specific 
charsets; now, if the JVM supports it, we don't need to do anything else.

> [email] Add new class Charset
> -----------------------------
>
>                 Key: EMAIL-54
>                 URL: https://issues.apache.org/jira/browse/EMAIL-54
>             Project: Commons Email
>          Issue Type: Improvement
>    Affects Versions: 1.0
>         Environment: Operating System: other
> Platform: Other
>            Reporter: Piero Ottuzzi
>            Priority: Minor
>         Attachments: charset-support.patch, Charset.java, Email.java.patch
>
>
> Add new class Charset the let the whole thing extensible and less error prone

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to