[ 
https://issues.apache.org/jira/browse/VFS-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482183
 ] 

Mario Ivankovits commented on VFS-106:
--------------------------------------

Hi!

I had a look at the source now, there are a few minor issues:

*) use of com.cirque namespace
You have to change it to the org.apache namespace if we should add it to VFS

*) use of "xxx.local" (the errors from the local file system provider) error 
messages
Even if we duplicate the messages, I'd prefer to not reuse these message. I'd 
say using .truezip should be fine.

*) e.printStackTrace
somewhere I've seen such a statement. If there is no other way to handle it you 
should wrap it in an RuntimeException.

*) test classes
please add a test class for this thing too - and check if it works ;-)


But the real blocker is, that I can't find truezip in any maven repository - 
you have to request it for upload - or ask the original author if he could 
upload it to the java.net maven repository; not sure about it.

Hmmm ... Or you simply host it at sourceforge. There is a plugin interface in 
VFS which allows you to provide a jar file and by simply dropping it into the 
classpath it will be activated ... so equally comfortable as if it is within 
the VFS repository ... what do you think?

Anyway - Thanks for the work
Ciao,
Mario

> VFS  Truezip provider
> ---------------------
>
>                 Key: VFS-106
>                 URL: https://issues.apache.org/jira/browse/VFS-106
>             Project: Commons VFS
>          Issue Type: New Feature
>            Reporter: Filip Defoort
>         Attachments: TzFileObject.java, TzFileProvider.java, TzFileSystem.java
>
>
> Attached is a quicky truezip provider to allow for read/write access to 
> zip/tar/... archives.
> See https://truezip.dev.java.net/ for details on truezip.
> Let me know how you want to proceed with something like this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to