[ 
https://issues.apache.org/jira/browse/DBCP-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489850
 ] 

Markus Krogemann commented on DBCP-146:
---------------------------------------

Phil, you are right. I got around the issue with a combination of 
testOnBorrow/testWhileIdle. 

Still, it would be an interesting addition to the already great capabilities of 
dbcp for the 'configuration-lazy' people among us ;-)

Having said that, it might even prove to be counter-productive to add features 
like that if users are not aware of them, so maybe it should not be implemented 
at all...

I am not in a position to decide that. However, if you are looking for testers 
of such a feature, i am prepared to help out.

Thanks for now,
Markus

> [dbcp] Invalidate "broken" connections by monitoring SQLExceptions
> ------------------------------------------------------------------
>
>                 Key: DBCP-146
>                 URL: https://issues.apache.org/jira/browse/DBCP-146
>             Project: Commons Dbcp
>          Issue Type: Improvement
>    Affects Versions: 1.1
>         Environment: Operating System: All
> Platform: All
>            Reporter: Dirk Verbeeck
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: brokenConn-patch.txt
>
>
> A PoolableConnection can know when it is "broken". (When a fatal SQLException 
> is
> thrown.) A SQLException is considered fatal when it includes an error code 
> from
> a configurable list of broken connection indicators.
> The attached patch is a partial implementation for review 
> (not all Delegating* methods are covered)
> Summary:
> Add a list of indicators that (when found in an SQLException) mark a 
> Connection
> as "broken". Broken Connections will be destroyed and not returned to the 
> pool.
> if (!isBroken()) {
>     _pool.returnObject(this);
> } else {
>     _pool.invalidateObject(this);
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to