[ https://issues.apache.org/jira/browse/BEANUTILS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497636 ]
Niall Pemberton commented on BEANUTILS-266: ------------------------------------------- Thanks for the suggestion - I used the HttpClient code. The only problem is I can't actually get PropertyUtilsBean's invoke method to throw an IllegalArgumentException in that place - other types of exceptions yes, but not that one. Looking at the code though I don't know why its only catching IllegalArgumentException and not any error. Any chance you could provide a test case that causes this? > Log or throw exception in PropertyUtilsBean, not both > ----------------------------------------------------- > > Key: BEANUTILS-266 > URL: https://issues.apache.org/jira/browse/BEANUTILS-266 > Project: Commons BeanUtils > Issue Type: Improvement > Components: Bean / Property Utils > Affects Versions: 1.7.0 > Environment: all > Reporter: Brian Ewins > Priority: Minor > Fix For: 1.8.0 > > > This commit (related to BEANUTILS-224): > http://svn.apache.org/viewvc/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/PropertyUtilsBean.java?view=diff&r1=471989&r2=471990 > improved the error message for illegal arguments, but also introduced a log > message for that same exception. Best practice is to log or throw but not > both, since this often results in the error being logged multiple times - > when it was created and when the exception is caught. In addition this is > logging the problem as an error when it may in fact be handled by the caller, > so at worst its a debug-level message. > I switched up to 1.7 recently and this has been filling up my logs. I know I > can work around it by disabling logging for this component but the existence > of this log message seems like an oversight. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]