[
https://issues.apache.org/jira/browse/EMAIL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Speakmon closed EMAIL-35.
-----------------------------
Resolution: Fixed
Assignee: Ben Speakmon
I just got in a fix for this. In addition to embedding plain DataSources, you
can also now embed Files directly.
> [email] Embedding raw DataSource Attachments
> --------------------------------------------
>
> Key: EMAIL-35
> URL: https://issues.apache.org/jira/browse/EMAIL-35
> Project: Commons Email
> Issue Type: Bug
> Affects Versions: 1.0
> Environment: Operating System: All
> Platform: All
> Reporter: Brandon Wolfe
> Assignee: Ben Speakmon
> Fix For: 1.1
>
> Attachments: EnhancedHtmlEmail.java, HtmlEmail.patch,
> HtmlEmailTest.patch
>
>
> I kick myself for not submitting this prior to 1.0. An important feature
> missing from org.apache.commons.mail.HtmlEmail is the ability to embed an
> arbitrary DataSource object. The current API only allows you to embed from a
> URL. My usage of CommonsEmail often includes the generation of image data
> on-the-fly, where it does not exist at a pre-defined URL.
> I propose the addition of a key method:
> public String embed(DataSource datasource, String name, String cid) throws
> EmailException
> This will allow us to attach our own datasources in addition to defining our
> own
> content-ids. Helper methods can be created to auto-generate CIDs when needed
> and allow for backwards compatability. I've found that being able to provide
> my
> own defined CIDs has been very helpful in referencing them in my velocity
> email
> templates.
> I will attach the current EnhancedHtmlEmail class that I have been using for a
> year or so. It extends HtmlEmail to provide the methods explained above. I
> would hope to have this capability introduced into the HtmlEmail class.
> Feel free to contact me to discuss further! Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
