Author: bayard Date: Tue Jul 17 11:27:26 2007 New Revision: 557008 URL: http://svn.apache.org/viewvc?view=rev&rev=557008 Log: Applying Niall's test and fix from BEANUTILS-92 - with my suggested changes of an improved debug message and a simplified test case
Added: jakarta/commons/proper/beanutils/trunk/src/test/org/apache/commons/beanutils/Jira92TestCase.java Modified: jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/PropertyUtilsBean.java Modified: jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/PropertyUtilsBean.java URL: http://svn.apache.org/viewvc/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/PropertyUtilsBean.java?view=diff&rev=557008&r1=557007&r2=557008 ============================================================================== --- jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/PropertyUtilsBean.java (original) +++ jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/PropertyUtilsBean.java Tue Jul 17 11:27:26 2007 @@ -241,11 +241,17 @@ for (int i = 0; i < origDescriptors.length; i++) { String name = origDescriptors[i].getName(); if (isReadable(orig, name) && isWriteable(dest, name)) { - Object value = ((DynaBean) orig).get(name); - if (dest instanceof DynaBean) { - ((DynaBean) dest).set(name, value); - } else { - setSimpleProperty(dest, name, value); + try { + Object value = ((DynaBean) orig).get(name); + if (dest instanceof DynaBean) { + ((DynaBean) dest).set(name, value); + } else { + setSimpleProperty(dest, name, value); + } + } catch (NoSuchMethodException e) { + if (log.isDebugEnabled()) { + log.debug("Error writing to '" + name + "' on class '" + dest.getClass() + "'", e); + } } } } @@ -254,11 +260,17 @@ while (names.hasNext()) { String name = (String) names.next(); if (isWriteable(dest, name)) { - Object value = ((Map) orig).get(name); - if (dest instanceof DynaBean) { - ((DynaBean) dest).set(name, value); - } else { - setSimpleProperty(dest, name, value); + try { + Object value = ((Map) orig).get(name); + if (dest instanceof DynaBean) { + ((DynaBean) dest).set(name, value); + } else { + setSimpleProperty(dest, name, value); + } + } catch (NoSuchMethodException e) { + if (log.isDebugEnabled()) { + log.debug("Error writing to '" + name + "' on class '" + dest.getClass() + "'", e); + } } } } @@ -268,11 +280,17 @@ for (int i = 0; i < origDescriptors.length; i++) { String name = origDescriptors[i].getName(); if (isReadable(orig, name) && isWriteable(dest, name)) { - Object value = getSimpleProperty(orig, name); - if (dest instanceof DynaBean) { - ((DynaBean) dest).set(name, value); - } else { - setSimpleProperty(dest, name, value); + try { + Object value = getSimpleProperty(orig, name); + if (dest instanceof DynaBean) { + ((DynaBean) dest).set(name, value); + } else { + setSimpleProperty(dest, name, value); + } + } catch (NoSuchMethodException e) { + if (log.isDebugEnabled()) { + log.debug("Error writing to '" + name + "' on class '" + dest.getClass() + "'", e); + } } } } Added: jakarta/commons/proper/beanutils/trunk/src/test/org/apache/commons/beanutils/Jira92TestCase.java URL: http://svn.apache.org/viewvc/jakarta/commons/proper/beanutils/trunk/src/test/org/apache/commons/beanutils/Jira92TestCase.java?view=auto&rev=557008 ============================================================================== --- jakarta/commons/proper/beanutils/trunk/src/test/org/apache/commons/beanutils/Jira92TestCase.java (added) +++ jakarta/commons/proper/beanutils/trunk/src/test/org/apache/commons/beanutils/Jira92TestCase.java Tue Jul 17 11:27:26 2007 @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.beanutils.bugs; + +import junit.framework.TestCase; + +import org.apache.commons.beanutils.PropertyUtils; +import org.apache.commons.beanutils.TestBean; + +/** + * Test case for Jira issue# BEANUTILS-92. + * <br/> + * See https://issues.apache.org/jira/browse/BEANUTILS-92 + * + * @version $Revision$ $Date$ + */ +public class Jira92TestCase extends TestCase { + + /** + * Test copy properties where the target bean only + * has an indexed setter. + */ + public void testIssue_BEANUTILS_92_copyProperties_indexed_only_setter() throws Exception { + PropertyUtils.copyProperties(new Jira92TestBean(), new TestBean()); + } + + /** + * Test bean which has only indexed setter + */ + public static class Jira92TestBean { + + private java.util.Date[] dateArrayProperty = new java.util.Date[10]; + + /** + * Indexed Setter. + * + * @param index index + * @param date indexed value to set + */ + public void setDateArrayProperty(int index, java.util.Date date) { + this.dateArrayProperty[index] = date; + } + } +} --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]