On Dec 5, 2007 1:50 AM, Ajith Ranabahu <[EMAIL PROTECTED]> wrote: > Hi Benson, > The suggested API change (I'm not sure whether this should be termed > an API change anyway. The earlier discussions implied to some extent > that it is a bug fix) and your patch are both applied in the release > branch (1.3.3). > Just to give some insight into what is happening let me explain the > situation. There are two methods getType[Element]Byname(Qname) that > used to look only inside the current schema. The problem is that Axis2 > code generator relies on this behavior. The argument was that since > you are passing a Qname this method should rightfully look in *all* > schemas (including the imported ones). So the posted RC has the > following changes > > 1. getType[Element]Byname(Qname) looks through all schemas > 2. Two new methods getType[Element]Byname(String) are added. These > look only inside the current Schema object for required type > > I'm sure if I change the trunk now Axis2 would break in its tests (not > during compilation) and that is why I am not so keen on putting it in > the trunk right now. After we test the RC (code from the branch) then > we can do the transition to the trunk.
hi ajith can you add this change to the trunk. I mean can you add new two methods to the Xml schema. Then according to that I can change the Axis2 and test. (Adding two method won't break anything.) It is bit difficult to test with your RC. thanks, Amila. > > > Ideas ? > > Ajith > > On Dec 4, 2007 12:13 PM, Benson Margulies <[EMAIL PROTECTED]> wrote: > > If you are breaking the API, why can't you include the 272 fix? The JIRA > > traffic said that it was being held off in a branch due to possibly > > disturbing existing users, but won't it pale in comparison with the main > > change under discussion? > > > > > > > -----Original Message----- > > > From: David Illsley [mailto:[EMAIL PROTECTED] > > > Sent: Tuesday, December 04, 2007 12:11 PM > > > To: [email protected] > > > Subject: Re: [Vote][XMLSchema] time for a release (again) > > > > > > Yeah, I'm suggesting that an API breaking change probably > > > shouldn't be in a x.x.1 version number. I'm also hesitant to > > > release with those changes if they've not been widely tested > > > e.g. on the trunk with Axis2. If it causes unanticipated > > > problems we'd be in a really unfortunate situation. > > > David > > > > > > On Dec 4, 2007 5:05 PM, Ajith Ranabahu > > > <[EMAIL PROTECTED]> wrote: > > > > Hi, > > > > I was only going with minor revision change but since we > > > are having an > > > > API change are you are you suggesting a major revision > > > number change ? > > > > (Like 1.4 maybe) Actually the Interface has only additions but the > > > > behavior of the method has changed. > > > > > > > > Ajith > > > > > > > > > > > > On Dec 3, 2007 6:27 PM, David Illsley > > > <[EMAIL PROTECTED]> wrote: > > > > > Hi Ajith, > > > > > I'm a little confused... what's the version number you > > > want this to go out with? > > > > > David > > > > > > > > > > > > > > > On Dec 3, 2007 10:27 PM, Ajith Ranabahu > > > <[EMAIL PROTECTED]> wrote: > > > > > > Hi all, > > > > > > I've fixed all the issues as discussed in the mailing list and > > > > > > posted the RC jars and zip files at > > > > > > http://people.apache.org/~ajith/xmlschema/<http://people.apache.org/%7Eajith/xmlschema/> > > > > > > > > > > > > This version has the API changed (not deprecated) and > > > is likely to > > > > > > break certain projects - especially Axis2. Hence I have not > > > > > > changed the trunk (since the snapshots will kick in and break > > > > > > things unexpectedly). As for the Jira issues I have > > > fixed 5 issues > > > > > > and marked > > > > > > 1 issue as wont fix since it seems to be something not directly > > > > > > related to XMLSchema. > > > > > > > > > > > > Please give the RC's a try and let us know whether this > > > is fit for > > > > > > a release :) > > > > > > > > > > > > -- > > > > > > Ajith Ranabahu > > > > > > > > > > > > Reading, after a certain age, diverts the mind too much > > > from its > > > > > > creative pursuits. Any man who reads too much and uses his own > > > > > > brain too little falls into lazy habits of thinking - Albert > > > > > > Einstein > > > > > > > > > > > > > > > ------------------------------------------------------------------ > > > > > > --- To unsubscribe, e-mail: > > > [EMAIL PROTECTED] > > > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > David Illsley - IBM Web Services Development > > > > > > > > > > > > > -------------------------------------------------------------------- > > > > > - To unsubscribe, e-mail: [EMAIL PROTECTED] > > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Ajith Ranabahu > > > > > > > > Reading, after a certain age, diverts the mind too much from its > > > > creative pursuits. Any man who reads too much and uses his > > > own brain > > > > too little falls into lazy habits of thinking - Albert Einstein > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > -- > > > David Illsley - IBM Web Services Development > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > -- > Ajith Ranabahu > > Reading, after a certain age, diverts the mind too much from its > creative pursuits. Any man who reads too much and uses his own brain > too little falls into lazy habits of thinking - Albert Einstein > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > -- Amila Suriarachchi, WSO2 Inc.
