Author: veithen
Date: Sun Feb 15 21:25:18 2009
New Revision: 744760
URL: http://svn.apache.org/viewvc?rev=744760&view=rev
Log:
Corrected an error message and some Javadocs. Added review comments.
Modified:
webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMContainer.java
webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMNode.java
webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMNodeImpl.java
Modified:
webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMContainer.java
URL:
http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMContainer.java?rev=744760&r1=744759&r2=744760&view=diff
==============================================================================
---
webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMContainer.java
(original)
+++
webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMContainer.java
Sun Feb 15 21:25:18 2009
@@ -35,6 +35,8 @@
*
* @param omNode
*/
+ // TODO: specify whether the node is removed from its original location
+ // TODO: specify what happens if the node has been created by a foreign
OMFactory
void addChild(OMNode omNode);
/**
Modified:
webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMNode.java
URL:
http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMNode.java?rev=744760&r1=744759&r2=744760&view=diff
==============================================================================
---
webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMNode.java
(original)
+++
webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMNode.java
Sun Feb 15 21:25:18 2009
@@ -90,7 +90,7 @@
static final short ENTITY_REFERENCE_NODE =
XMLStreamConstants.ENTITY_REFERENCE;
/**
- * This node is an <code>Entity Reference</code>.
+ * This node represents white space.
*
* @see #getType()
*/
@@ -135,6 +135,7 @@
* @throws OMException If a node is not complete, the detach can trigger
further parsing, which may
* cause an exception.
*/
+ // TODO: LLOM's OMNodeImpl triggers an exception if the node doesn't have
a parent. This is not specified here.
OMNode detach() throws OMException;
/**
Modified:
webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMNodeImpl.java
URL:
http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMNodeImpl.java?rev=744760&r1=744759&r2=744760&view=diff
==============================================================================
---
webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMNodeImpl.java
(original)
+++
webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMNodeImpl.java
Sun Feb 15 21:25:18 2009
@@ -193,7 +193,7 @@
public OMNode detach() throws OMException {
if (parent == null) {
throw new OMException(
- "Elements that doesn't have a parent can not be detached");
+ "Nodes that don't have a parent can not be detached");
}
OMNodeImpl nextSibling = (OMNodeImpl) getNextOMSibling();
if (previousSibling == null) {
