On Fri, Apr 3, 2009 at 10:45 PM, Jarek Gawor <jga...@gmail.com> wrote:
> The local module and http module (source only) is now moved to Axis2. > Please give it a try and see if things look ok. If so, we'll merge it > to 1.5 branch. I ran some sample tests with a sanpshot release and it worked fine. (tested with both simple http server and war under tomcat) So we can move it to branch and remove the transport dependency. > > I kept the http module in the Transport project but I had to change > the artifact name to prevent a conflict with the Axis2 http transport > module. Btw, I think that the Transport project should have its own > group id (e.g org.apache.axis2.transport instead of org.apache.axis2). but anyway we are going to remove the http and local transports from the commons transport module isn't it? IMHO also transport module should have a different group id and a package structure. thanks, Amila. > > The Transport http module only has the tests now. If we could refactor > the tests somehow that would be great but I guess it's not critical > for 1.5. > > Thanks, > Jarek > > On Thu, Apr 2, 2009 at 5:15 PM, Glen Daniels <g...@thoughtcraft.com> > wrote: > > Hi folks: > > > > First, many thanks to Jarek for getting the transport move going - I got > > sucked into other stuff today and probably won't be able to dive back in > for > > real until Sunday. Just talked to Jarek on IRC and he's hoping to finish > the > > move tonight or tomorrow. > > > > That said.... I'm not very happy about the idea of leaving important > tests in > > the WS-Commons area if the code they're testing is actually in Axis2. > This > > smells of bad refactoring and future confusion. > > > > I want to get Axis2 1.5 out ASAP, and am willing to do whatever gets us > there > > quickest, but after that I'd like to have another discussion about how to > > correctly host and factor the transports code. This should dovetail > nicely > > with another round of the "Splitting WS" conversation, which I'd like to > have > > at the same time. > > > > Thanks, > > --Glen > > > > Andreas Veithen wrote: > >> Note that the tests applied to the (default Axis2) HTTP transport > >> initially were not meant to test the transport but to validate the > >> generic HTTP tests in the testkit. The purpose was to apply these > >> generic tests to the NIO HTTP transport. This allows to compare the > >> behavior of both transports. From that perspective we may leave the > >> tests in the transports project ... as tests for the testkit :-) > >> > >> Andreas > >> > >> On Thu, Apr 2, 2009 at 17:08, Jarek Gawor <jga...@gmail.com> wrote: > >>> On Wed, Apr 1, 2009 at 5:50 PM, Glen Daniels <g...@thoughtcraft.com> > wrote: > >>>> Jarek Gawor wrote: > >>>>>> Also, I'd really like to get 1.5 out the door ASAP, it's lingered > way too > >>>>>> long already. So whatever solution gets us there soonest with > consensus is > >>>>>> the one I'll be happy with. > >>>>> Yes, I agree. Sounds like we already agree on a solution (moving http > >>>>> and local back to Axis2). > >>>> OK, I'm on this tomorrow. If anyone has issues with it, please pipe > up! > >>> I already moved some of the utility classes and methods back to Axis2 > >>> and eliminated a direct dependency on transport base from http and > >>> local. But once I was actually looking into moving the http module to > >>> Axis2 I realized the the http transport tests have dependency on the > >>> testki module which has dependencies on the transport base module.... > >>> So we can easily move the transport http code itself but not the > >>> tests... anybody have ideas how to deal with this now? > >>> > >>> Jarek > >>> > > > -- Amila Suriarachchi WSO2 Inc. blog: http://amilachinthaka.blogspot.com/
