> 1) Line length of 80 > In most of the places that we are exceeding the limit, we are just over > by a bit (between 80 and 90). I propose that we change the max length > to 100. This is still short enough that nobody should have to scroll to > see the source but long enough that we aren't artificially breaking lines.
Sure. We use 100 for checkstyle here too. > 2) Instance variable names > Some of the code uses leading underscores for variable names but this > isn't allowed by checkstyle. The pattern it checks for is > ^[a-z][a-zA-Z0-9]*$ > I find significant benefit to being able to quickly distinguish instance > variables from local variables and the leading underscore lets me do > that easily. (I personally prefer trailing underscores to leading ones > but I can live with either) > > I propose that we change the pattern for instance variables to > ^_?[a-z][a-zA-Z0-9]*$ so that we will allow leading underscores but will > not insist on it. Uuuugh, please no! Besides being ugly, it's worth sticking to the Sun coding style (as is the default with checkstyle). That way, anyone who has done any Java will be immediately familiar with it. $0.02 Simon -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
