- no need for fully qualified class names in @see or @link comments
- please use @since 2.0beta1 new methods/classes
- don't see a need for getFirstHeader and getLastHeader
- getCondensedHeader, if there is one header, it returns a refrence to an internal datastructure, if more than one, it returns a copy. Its an optimization, somehow I'm torn about it

Can we do this with zero changes to the HttpMethod interface? The users do not need access to the HeaderGroup; it'd be nice if it was package access rather than public.. They can always use the Header[] form, which is more general to them anyway. Its only internally that a HeaderGroup object is required. ... Not sure how to mitigate that with that interface.

[EMAIL PROTECTED] wrote:

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11218>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11218

handle multivalue headers correctly





------- Additional Comments From [EMAIL PROTECTED] 2003-02-04 03:31 -------
The above patch is a first attempt at solving this problem.

What's new:
- HeaderGroup, a new class for storing headers. This class supports multiple
headers with the same name and it remembers header order. I'm not a huge fan of
the name, but it was the best I could come up with.
- HeaderParser, a new class for parsing headers. Header parsing code was
duplicated in HttpMethodBase and ChunkedInputStream and was placed here.
- HttpMethod has 3 new methods. getRequestHeaderGroup(),
getResponseHeaderGroup(), and getResponseFooterGroup(). This will break an
existing extension of HttpMethod.
- Some of the methods for accessing headers in HttpMethod have been deprecated.
- Classes in the general codebase that use the newly deprecated methods have
been fixed. Some of the test cases are still using deprecated methods.
- SimpleHttpConnection and SimpleHttpMethod have been changed to work correctly
with the new header storage method.

Please take a look and let me know what you think.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to