Eeek! Sorry, I should have been more explicit that I am using an old version here (old version at work, latest version at home). We had to release our product something like two months ago (before the HttpMultiClient merge) and went with a nightly HttpClient from around that time. We're waiting on the final 2.0 release to upgrade to since it will involve a non-trivial amount of work. I've obviously misremembered the previous conversation about whether to send an IP address or not, I didn't think any change was actually made.

Obviously from the code that Eric posted, a change was made so the IP address is now sent. Serves me right for sending email in reaction to a tech support query that wasn't assigned to me while fighting with the Xerces internal API. :) Sorry for the distraction, though it does provide an excellent justification for the change...

Adrian Sutton.

On Wednesday, April 2, 2003, at 07:47 PM, Kalnichevski, Oleg wrote:

I believe that it can be safely assumed that HttpConnection#getHost() never returns an empty string if the connection has been successfully open (which is the case by the time HttpMethodBase#addHostRequestHeader() gets executed. In other words HttpConection#open() cannot succeed, if the host name is invalid, null, or blank

So, something is really fishy here.

Oleg

-----Original Message-----
From: Eric Johnson [mailto:[EMAIL PROTECTED]
Sent: Mittwoch, 2. April 2003 03:45
To: Commons HttpClient Project
Subject: Re: Host Header and IP Addresses


Adrian,


Weird.  I just went and looked at the code again to refresh my memory.
Based on the code, and what I recall of the previous discussion, we had
agreed that sending the IP address for the host when none other was
specified.
<snip>


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to