Odi, Looks good to me. I think the patch is good to be checked in Oleg
-----Original Message----- From: Ortwin Glück [mailto:[EMAIL PROTECTED] Sent: Monday, July 21, 2003 10:12 AM To: Commons HttpClient Project Subject: Re: [PATCH] Documentation Index: charencodings.xml =================================================================== RCS file: /home/cvspublic/jakarta-commons/httpclient/xdocs/charencodings.xml,v retrieving revision 1.2 diff -u -r1.2 charencodings.xml --- charencodings.xml 11 Mar 2003 08:03:12 -0000 1.2 +++ charencodings.xml 21 Jul 2003 08:09:50 -0000 @@ -25,7 +25,10 @@ It is not possible to use non <tt>US-ASCII</tt> characters in the header of a request or response. Generally this is not an issue however, because the HTTP headers are designed to facilite the transfer of data rather than to - actually transfer the data itself. + actually transfer the data itself.</p> + <p>One exception however are cookies. Since cookies are transfered as HTTP Headers + they are confined to the <tt>US-ASCII</tt> character set. See the Cookie Guide + for more information. </p> </section> Index: cookies.xml =================================================================== RCS file: /home/cvspublic/jakarta-commons/httpclient/xdocs/cookies.xml,v retrieving revision 1.2 diff -u -r1.2 cookies.xml --- cookies.xml 3 Jun 2003 21:26:35 -0000 1.2 +++ cookies.xml 21 Jul 2003 08:09:50 -0000 @@ -131,5 +131,17 @@ non-compliant servers. In these cases, switching to the compatibility cookie specification usually solves the problem.</p> </section> + + <section name="Encoding Issues"> + <p>Since cookies are transfered as HTTP Headers they are confined to + the <tt>US-ASCII</tt> character set. Other characters will be lost or + mangeled. Cookies are typically set and read by the same server, so + a custom scheme for escaping non-ASCII characters can be used, for + instance the well-established URL encoding scheme. If cookies are + used to transfer data between server and client both parties must + agree on the escaping scheme used in a custom way. The HttpClient + cookie implementation provides no special means to handle non-ASCII + characters nor does it issue warnings.</p> + </section> </body> </document> Kalnichevski, Oleg wrote: > Odi, > You are absolutely right. We have to mention in the encoding guide or/and cookie > guide that cookies must conform to encoding requirements for the HTTP headers, that > is, 'funny' non-US-ASCII characters will be lost. > > Oleg --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
