Dang, first you forgot your attachment, now I'm answering to the wrong mail :-)
/Oliver
On Donnerstag, Okt 16, 2003, at 18:19 Europe/Berlin, Oliver Köll wrote:
Hi Oleg,
thanks for the fast turnaround - but, which patch do you mean?
Cheers, Oliver
On Donnerstag, Okt 16, 2003, at 12:12 Europe/Berlin, Kalnichevski, Oleg wrote:
Hi Olver,
See my comments in-line
I'm dealing with a site that serves invalid Cookies in various kind of
ways. In some cases the Cookie values contain "," characters, which
really confuses the Header/Cookie parsers and eventually leads to
IllegalArgumentExceptions thrown by the Cookie constructor:
This is not that easy. Commas in cookie headers are enormously hard to deal with because it can never tell if
param=stuff,more_stuff
is meant to be
param="stuff,more_stuff"
or
param=stuff, more_stuff=null
Anyways, I'll tweak the CookieSpecBase to avoid attempts to create an instance of Cookie class if cookie name is invalid.
What bothers me, is that these IllegalArgumentExceptions are never caught in the HttpClient code, making it effectivily impossible to handle these responses.
Fair enough. I'll review the cookie parser and make sure that it throws MalformedCookieException exception if it comes across an invalid cookie header
3) Finally, wouldn't it be nice to have the possibility to plug-in your
own custom Cookie parser, allowing more control with parsing/validating
bad Cookies? Something like
This is a well known limitation whose resolution is targeted for 2.1 release
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21151
Cheers
Oleg
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
