Tim,
I tried to make a test case for the alleged bug in the
HttpParser#readRawLine, but failed to reproduce it. As far as I am
concerned the HttpParser is actually OK. The results produced by
HttpParser in my opinion make sense. I attach a test case below that I
believe supports my assertion. If there is something that I am missing,
please do not hesitate to point it out.
The real culprit in my opinion is this code in
HttpMethodBase#readStatusLine(HttpState, HttpConnection)
<snip>
//read out the HTTP status string
String statusString = conn.readLine();
while ((statusString != null) && !statusString.startsWith("HTTP")) {
...
statusString = conn.readLine();
}
</snip>
The code above would also fail to recognise a response status line if it
had a blank or a series of blanks in front of "HTTP".
I'll be working on a patch to address the problem.
Many thanks for tracking it down, though.
Cheers
Oleg
On Wed, 2003-10-15 at 23:28, Tim McCune wrote:
> This patch is against 2.0rc2.
> I ran into a problem where the HttpClient kept thinking that the
> connection was closed while talking to an IIS 5.0 server, even though my
> web browser could load the page fine. Turns out that the server was
> sending a line feed as the first byte of the response, which HttpClient
> treats as a closed connection due to a bug in HttpParser.
/*
* $Header$
* $Revision$
* $Date$
* ====================================================================
*
* The Apache Software License, Version 1.1
*
* Copyright (c) 1999-2003 The Apache Software Foundation. All rights
* reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
*
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in
* the documentation and/or other materials provided with the
* distribution.
*
* 3. The end-user documentation included with the redistribution, if
* any, must include the following acknowlegement:
* "This product includes software developed by the
* Apache Software Foundation (http://www.apache.org/)."
* Alternately, this acknowlegement may appear in the software itself,
* if and wherever such third-party acknowlegements normally appear.
*
* 4. The names "The Jakarta Project", "Tomcat", and "Apache Software
* Foundation" must not be used to endorse or promote products derived
* from this software without prior written permission. For written
* permission, please contact [EMAIL PROTECTED]
*
* 5. Products derived from this software may not be called "Apache"
* nor may "Apache" appear in their names without prior written
* permission of the Apache Group.
*
* THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
* WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
* ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
* USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
* ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
* OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
* ====================================================================
*
* This software consists of voluntary contributions made by many
* individuals on behalf of the Apache Software Foundation. For more
* information on the Apache Software Foundation, please see
* <http://www.apache.org/>.
*
* [Additional notices, if required by prior licensing conditions]
*
*/
package org.apache.commons.httpclient;
import java.io.ByteArrayInputStream;
import java.io.InputStream;
import junit.framework.*;
/**
* Simple tests for [EMAIL PROTECTED] HttpParser}.
*
* @author Oleg Kalnichevski
* @version $Id$
*/
public class TestHttpParser extends TestCase {
// ------------------------------------------------------------ Constructor
public TestHttpParser(String testName) {
super(testName);
}
// ------------------------------------------------------------------- Main
public static void main(String args[]) {
String[] testCaseName = { TestHeader.class.getName() };
junit.textui.TestRunner.main(testCaseName);
}
// ------------------------------------------------------- TestCase Methods
public static Test suite() {
return new TestSuite(TestHttpParser.class);
}
public void testReadHttpLine() throws Exception {
InputStream instream = new ByteArrayInputStream(
"\r\r\nstuff\r\n".getBytes("US-ASCII"));
assertEquals("\r", HttpParser.readLine(instream));
assertEquals("stuff", HttpParser.readLine(instream));
assertEquals(null, HttpParser.readLine(instream));
instream = new ByteArrayInputStream(
"\n\r\nstuff\r\n".getBytes("US-ASCII"));
assertEquals("", HttpParser.readLine(instream));
assertEquals("", HttpParser.readLine(instream));
assertEquals("stuff", HttpParser.readLine(instream));
assertEquals(null, HttpParser.readLine(instream));
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
