DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24671>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24671

Basic Authentification fails with non-ASCII username/password characters





------- Additional Comments From [EMAIL PROTECTED]  2003-12-10 00:40 -------
> So, how about this?
>
> AuthScheme#authenticate(Credentials credentials, HttpMethod method) throws
> AuthenticationException;

I agree I think that is much better.  I will make the change.

> * EncodingUtil renders HttpConstants superfluous. HttpConstants begs to be
> deprecated and EncodingUtil should be used consistently throughout HttpClient
> base instead. Keeping both classes makes things unnecessarily confusing.

Yes, HttpConstants has become a little useless.  Once this patch has been applied I 
will take this 
on as a separate task.

> * I feel HTTP_ELEMENT_CHARSET can simply be used instead of CREDENTIAL_CHARSET. 

I would prefer to keep them separate.  Though I think the majority of the cases will 
only use 
HTTP_ELEMENT_CHARSET, I can definitely imagine a case where the credentials would 
require a 
different charset than the headers.  I know that in some server configurations 
authorization is 
handled separately from other content.  What do you think?

Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to