DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=28322>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=28322 Connection timeout logic redesign ------- Additional Comments From [EMAIL PROTECTED] 2004-04-12 18:03 ------- A tiny detail, but a possibly confusing one for people reading the code -- the comments in ReflectionSocketFactory that explain what the reflection code is doing don't include the step that uses "SocketFactory.getDefault()". This confused me mostly because getDefault was static, and I didn't realize that it was expected that each subclassed SocketFactory would implement it's own getDefault behaviour. It also seems a bit odd to use the String equality to test for an exception of SocketTimeoutException. Perhaps now that the classes are being statically cached, a SocketTimeoutException.class could be created and the catch clause could use SOCKETTIMEOUTEXCEPTION_CLASS.isInstance(cause). --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
