Hi Hendrik, Hendrik Maryns wrote on Thursday, July 06, 2006 10:59 AM:
> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi all, > > The javadocs in DefaultedMap is very inconsistent. It speaks > of factory > when a transformer is meant, it speaks of transformer when value is > meant and that sort of stuff. > > Besides, it would be much cleaner to declare 'value' of type > Transformer, and create a transformer every time, except when one is > passed (the instanceof checks are wrong anyway), (I'd rename it to > transformer, too). > > Even nicer would be to split up the constructor(s) into one > that takes a > value, and one that takes a Transformer, no instanceof checks needed, > much cleaner code, generification is almost trivial :-) > > I attached what I made of it, removing the generic markers gives a > perfectly legal 1.4 file. We really appreciate your effort, but this won't work. Please create a JIRA account for yourself and file an issue here: http://issues.apache.org/jira/browse/COLLECTIONS Add your modifications as attachment in for of a *diff*. Otherwise no-one really knows what you have changed - especially if development went on. In that case your changes would simply ignored and *that* would be a real waste of time and effort. Thanks, Jörg --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
