Hello Dominic & list,

Over the past few days I have been using OWSLib for a project and found a few 
potential issues I have mentioned on the mailing list. I thought I would send 
this out detailing some modifications/fixes and providing a possible patch for 
trunk revision 1566 if you think it makes sense.

wms.py
------ 
- File has mixed tabs and spaces (failing the old tabnanny check), changed to 
all spaces.

- Added a method to return the full capabilites xml.

- Changed ServiceException a bit, it should be backward compatible (still 
return the simple error message as before) but also contains the service 
exception xml.

- I had a look at the OGC wms 1.1.1 specifications 
(http://www.opengeospatial.org/standards/wms) and it looks like OWSLib might be 
processing WMS layer information incorrectly. Somebody probably knows a lot 
more about the spec than me, but it looks to me that the parent layer styles 
(sec 7.1.4.4) and SRS (7.1.4.5.5) are supposed to be inherited (and possible 
overridden) by the child layers. Currently wms.py only uses the parent 
information if the child has none of it's own. I changed wms.py to copy this 
info (and possibly override it) from each layers parent.

util.py
-------
- Has a previously mentioned error that prevents authenticated wms from 
working, fixed this.


If anybody has any comments on these things I would like to hear them because I 
could be mistaken about some of them.

thanks,

Angus


      __________________________________________________________________
Yahoo! Canada Toolbar: Search from anywhere on the web, and bookmark your 
favourite sites. Download it now
http://ca.toolbar.yahoo.com.

Attachment: wms.py
Description: application/download

Attachment: util.py
Description: application/download

_______________________________________________
Community mailing list
[email protected]
http://lists.gispython.org/mailman/listinfo/community

Reply via email to