Where's your test Levi? *chuckle* Hope that helps. CE is using Test::Unit
On Mon, Dec 15, 2008 at 10:23 AM, Levi Rosol <[email protected]> wrote: > good news. groups now have all of the functionality a user would have. > membership has been implemented, photos, and comments. I will spend this > week cleaning up a few things, but am planning to move everything that > should be in the CE core into the CE plugin and will then ask for someone to > help me get the code into the git repos. > > What are the testing requirements for code in this project? At this point, > i've written zero tests for the new functionality. partly due to me wanting > to use rspec instead of ::test, but mostly because I don;t have anyone > looking over my sholder saying "where's your test at levi?" :-) > > > > -- > Levi Rosol > Twitter: @LeviRosol > > > On Thu, Dec 11, 2008 at 11:57 AM, Bruno Bornsztein > <[email protected]> wrote: >> >> You'd need to install git on your machine, sign up for an account at >> github, and push your local repository to github. There's a bit of a >> learning curve with git, but it's well worth it (IMO). >> >> http://git-scm.com/ >> >> >> >> On Thu, Dec 11, 2008 at 9:30 AM, Levi Rosol <[email protected]> wrote: >>> >>> What is the process for me adding it to github? I currently use svn for >>> my scm, and won;t be able to open it up for others to use. >>> >>> I am going to spend some time on it this weekend, and will work to get my >>> additions moved to the CE plugin folder. There's really no reason for these >>> to live in my app folder for now. >>> >>> -- >>> Levi Rosol >>> Twitter: @LeviRosol >>> >>> >>> On Thu, Dec 11, 2008 at 8:56 AM, Bruno Bornsztein >>> <[email protected]> wrote: >>>> >>>> Hi Levi, >>>> I'd be happy to take a look at what you have now, although the best >>>> solution would be for you to put your work up on github (or some other scm) >>>> so everyone can have a look. This is for two reasons: >>>> 1) If this work is compatible with CE core, I may not get around to >>>> integrating it for a while, someone else might get to it faster >>>> 2) Even if it doesn't go into the core, others could use your work as a >>>> starting point for doing their own groups implementation >>>> >>>> If you're worried about putting your entire app out there, you could >>>> just share the relevant portions. >>>> >>>> Thanks, >>>> Bruno >>>> >>>> >>>> On Wed, Dec 10, 2008 at 11:09 PM, Levi Rosol <[email protected]> >>>> wrote: >>>>> >>>>> As of right now groups can be created, a location assigned, photos and >>>>> avatars uploaded, and can be searched on by name and location. Activities >>>>> are also functional, so you see things like "levi created a new group" in >>>>> the "what's fresh" section of your pages. There are also grouproles, and i >>>>> currently have the Owner role functional. >>>>> >>>>> My next task is implementing membership functionality (and role), then >>>>> comments. >>>>> >>>>> >>>>> All of this has been kept generic with the intent of giving back to CE. >>>>> However, I'm not confident that i have done this in the best was for the >>>>> CE >>>>> core for a few reasons that i see. First, i'm a Rails noob :-) because of >>>>> this, everything new that I have created has gone into my app folder, not >>>>> the CE plugin. second, I have duplicated many pieces of functionality. For >>>>> example, to get photos tied to a group, i literally copy/pasted the photo >>>>> model, renamed to groupphoto in my app folder, and esentually did a find >>>>> replace on user for group. I'm not saying that this won't work, because it >>>>> will, I'm just not personally happy with the code structure. it is very >>>>> very >>>>> dirty IMO. Really, it's more un-DRY than dirty. >>>>> >>>>> The second reason is, i have no idea how to merge my stuff into CE's >>>>> git repos. This is probably minor, but it will require work on bruno's >>>>> part. >>>>> >>>>> On the positive, merging into the CE core should be easy as i have >>>>> commented every place in the CE core that i have modified or added to >>>>> consistently. I have also took the time to use the multi-ligual tags, so >>>>> renaming labels throught the new views should be easy. >>>>> >>>>> I'm not sure what my plan is for memberships yet. i could go the route >>>>> of extending the existing friendship model, or i could go the route of >>>>> making new models as this would provide cleaner separation. >>>>> >>>>> For comments, i think that one is clear in that i'll add onto the >>>>> existing model. A comment is a comment. >>>>> >>>>> >>>>> >>>>> All of this said, now may be a good time for me to package up what I >>>>> have and send to bruno before i start on anything else. >>>>> >>>>> Bruno, got any thoughts on this? I can continue on and we can clean up >>>>> later. Or, we can clean now, and do, hopefully, less clean up later. >>>>> >>>>> As for a timeline, it is my goal to have my site lauched with the >>>>> functionality described above by the end of the year. I think that is very >>>>> realistic, however, i cannot make any promises for your site. >>>>> >>>>> -- >>>>> Levi Rosol >>>>> Twitter: @LeviRosol >>>>> >>>>> >>>>> On Wed, Dec 10, 2008 at 8:56 PM, Alexis <[email protected]> >>>>> wrote: >>>>>> >>>>>> Hi Levi, >>>>>> Do you have an ETA for the next phase of this functionality? We now >>>>>> realize that we really need this at IMspirit.com, too, and eagerly >>>>>> await your news. >>>>>> ~ Alexis >>>>>> >>>>>> On Dec 2, 11:04 am, "Levi Rosol" <[email protected]> wrote: >>>>>> > So now i have the following models: >>>>>> > >>>>>> > Group >>>>>> > Membership >>>>>> > GroupRole < Role >>>>>> > Group_Permission >>>>>> > >>>>>> > Currently you can create a new Group. When you do, the current_user >>>>>> > is added >>>>>> > to the Membership collection and gets the Owner permission added. >>>>>> > The index view lists the Groups >>>>>> > When you view a group, you just see the Group info >>>>>> > >>>>>> > Next on my plate is to build out the Group profile page. I'll post >>>>>> > my >>>>>> > updates as I have them. >>>>>> > >>>>>> > Levi Rosol >>>>>> > Twitter: @LeviRosol >>>>>> > >>>>>> > On Tue, Nov 25, 2008 at 9:15 AM, Levi Rosol <[email protected]> >>>>>> > wrote: >>>>>> > > I started last night and should have something to show soon. I'm >>>>>> > > trying to >>>>>> > > keep this initial run at this generic, and will worry about my >>>>>> > > project >>>>>> > > specific stuff after i send it to you. >>>>>> > >>>>>> > > Levi >>>>>> > >>>>>> > > On Tue, Nov 25, 2008 at 9:01 AM, Bruno Bornsztein < >>>>>> > > [email protected]> wrote: >>>>>> > >>>>>> > >> I don't plan on working on it anytime soon (not high on my >>>>>> > >> priorities >>>>>> > >> list). Let me know when you make some headway, I'd love to check >>>>>> > >> out the >>>>>> > >> repo. >>>>>> > >> Thanks, >>>>>> > >> Bruno >>>>>> > >>>>>> > >> On Mon, Nov 24, 2008 at 3:40 PM, Levi Rosol >>>>>> > >> <[email protected]> wrote: >>>>>> > >>>>>> > >>> Anyone planning to jump on this? If not, i will, but i can't put >>>>>> > >>> any >>>>>> > >>> guarantees when it will be done as it will be a learning process >>>>>> > >>> for me >>>>>> > >>> throughout. >>>>>> > >>>>>> > >>> Levi >>>>>> > >>>>>> > >>> On Fri, Nov 21, 2008 at 11:45 AM, Levi Rosol >>>>>> > >>> <[email protected]>wrote: >>>>>> > >>>>>> > >>>> So how should we go about attacking this? >>>>>> > >>>>>> > >>>> Levi >>>>>> > >>>>>> > >>>> On Fri, Nov 21, 2008 at 9:21 AM, Max Schubert >>>>>> > >>>> <[email protected]>wrote: >>>>>> > >>>>>> > >>>>> On Fri, Nov 21, 2008 at 8:14 AM, Bruno Bornsztein >>>>>> > >>>>> <[email protected]> wrote: >>>>>> > >>>>> > Hi guys, before things get too complicated, here's more of >>>>>> > >>>>> > what I had >>>>>> > >>>>> in >>>>>> > >>>>> > mind: >>>>>> > >>>>>> > >>>>> > Profile is just a container for things that go on the >>>>>> > >>>>> > profile page >>>>>> > >>>>> for a >>>>>> > >>>>> > group or user, and has a polymorphic association (so it can >>>>>> > >>>>> > be >>>>>> > >>>>> associated >>>>>> > >>>>> > with anything, really). Users stay the same, group is a new >>>>>> > >>>>> > object, >>>>>> > >>>>> and >>>>>> > >>>>> > users belong to a group through a Membership, which also >>>>>> > >>>>> > describes >>>>>> > >>>>> the users >>>>>> > >>>>> > Role in the group (admin, moderator, member) via the >>>>>> > >>>>> > existing Roles >>>>>> > >>>>> table. >>>>>> > >>>>>> > >>>>> > Make sense? >>>>>> > >>>>>> > >>>>> Very nice :) >>>>>> >>>>> >>>>> >>>>> >>>> >>>> >>>> >>> >>> >>> >> >> >> > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "CommunityEngine" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/communityengine?hl=en -~----------~----~----~----~------~----~------~--~---
