On closer examination, I see that all the tests that fail are because of the handling of spaces.
The tests create objects with tag_list="tag1 tag2" and then expect it to create two tags. If I change all the tests to expect tags to be comma-separated, then they all pass fine. I guess we're getting into an area of opinion, and Bruno's is the opinion that matters (as far as what goes into the official repo). Based on experience with my CE site (as well as having developed numerous other sites that rely on AAToS), and also based on feedback Bruno provided previously in this thread, here is what I recommend: 1. Use only a comma as a tag separator in input text fields. 2. Allow spaces and plus signs in tag names (not as separators) I think this makes usage predictable and intuitive. As far as I can tell, simply changing the setting for the delimiter back to the default of a comma (and updating the functional tests) seems to accomplish this. Bruno -- can you weigh in here? Are there other things that will not work right this way? Perhaps things that don't have tests yet? Btw, I created a simple tag admin interface. I will send a pull request for this some time this weekend. On Jul 1, 6:22 pm, eksatx <[email protected]> wrote: > You are on the right track, but there must be more to it than that. > > 1. That is how that file started out. It was changed to its current > state to fix some other bug. > 2. Changing it back causes 10 tests to fail. > > I have entered a bug. With any luck Bruno can shed some light on the > situation. > > Meanwhile, I am going to move ahead with creating an admin interface > for editing tags. I think that will be useful regardless of the > outcome of this particular issue. > > On Jul 1, 4:11 pm, sprite <[email protected]> wrote: > > > Changing delimiter to > > > self.delimiter = ',' > > > in tag_list.rb seems to take care of the problem. Let me know if that > > works. > > > On Jul 1, 1:34 pm, Bruno Bornsztein <[email protected]> > > wrote: > > > > Great. Thanks! > > > > On Wed, Jul 1, 2009 at 9:59 AM, Errol Siegel <[email protected]> > > > wrote: > > > > Thanks for the feedback. > > > > > Just to clarify: the item about showing tags in a comma-separated list > > > > only > > > > applies to the New and Edit views -- they are shown separated by plus > > > > signs > > > > in the text input field. > > > > > I have used AATOS in other projects and not seen these behaviors so what > > > > you are saying makes sense -- there may be some bugs in the CE code > > > > that is > > > > causing these issues. > > > > > I'll come up with some specific, reproducible use cases. If you agree > > > > that > > > > they are bugs then I'll add them to Lighthouse (and help fix them). > > > > > On Wed, Jul 1, 2009 at 6:40 AM, Bruno Bornsztein < > > > > [email protected]> wrote: > > > > >> These are use cases that *should* be covered > > > >> (acts_as_taggable_on_steroids is built to cover them). If they aren't > > > >> working, I consider these bugs, not feature requests. > > > > >>> 1. Disallow any whitespace in the tag_list input > > > > >> Not necessary. > > > > >>> 2. Allow only alphanumeric characters in the tag_list input > > > > >> Probably not needed: tags should be URL encoded when used in route > > > >> generation. > > > > >>> 3. Display the tag list separated by commas > > > > >> Sure, that's fine... I often use a little tag icon by each tag as well. > > > > >>> 4. Automatically Capitalize tags -- not sure if everybody would want > > > >>> this > > > > >> I'd say no to this. > > > > >>> 4. Provide a tag admin interface so the administrator can easily edit/ > > > >>> delete tags (mainly to make it easy to delete inappropriate tags). > > > > >> Great idea! > > > > >> Bottom line: sounds like our tagging implementation is a little broken > > > >> (not handling commas, quotes correctly) and needs fixing. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "CommunityEngine" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/communityengine?hl=en -~----------~----~----~----~------~----~------~--~---
