I committed my changes, but don't know how to see my branch on github: ~/rails/omni.preB1/vendor/plugins/community_engine muld...@fedora$ git status # On branch master # Changed but not updated: # (use "git add <file>..." to update what will be committed) # # modified: app/controllers/users_controller.rb # modified: app/views/users/show.html.haml # no changes added to commit (use "git add" and/or "git commit -a")
~/rails/omni.preB1/vendor/plugins/community_engine muld...@fedora$ git commit -am 'hooked up profile view count for users' Created commit c51cfee: hooked up profile view count for users 2 files changed, 9 insertions(+), 1 deletions(-) ~/rails/omni.preB1/vendor/plugins/community_engine muld...@fedora$ git status # On branch master # Your branch is ahead of 'origin/master' by 1 commit. # nothing to commit (working directory clean) And yes, I still need to write some tests, but learning this process is part of that. Where can I inspect my branch on github? On Tue, Aug 4, 2009 at 11:10 AM, Bruno Bornsztein<[email protected]> wrote: > Hi Mike, > Just go ahead and commit your changes to your own branch, and then send me a > pull request (assuming you're using Github) > Thanks, > Bruno > On Fri, Jul 31, 2009 at 4:52 PM, mike muldoon <[email protected]> > wrote: >> >> users_controller.rb does include Viewable, but lacks this method: >> >> def update_views >> �...@user= User.find(params[:id]) >> updated = update_view_count(@user) >> render :text => updated ? 'updated' : 'duplicate' >> end >> >> ..and the corresponding call needs to be added to >> /vendor/plugins/community_engine/app/views/users/show.html.haml: >> >> %script{:type=>"text/javascript", :charset=>"utf-8"} >> = remote_function :url => {:controller => 'users', :action => >> 'update_views', :id => @user}, :method => :put >> >> >> I'd like to write some tests, and check these in. How do I go about >> submitting changes? Is there a branch I commit to for Bruno's review? >> >> thx! >> Mike >> >> > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "CommunityEngine" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/communityengine?hl=en -~----------~----~----~----~------~----~------~--~---
