Steve,

It mainly looks okay to me, just a minor comments (see below) ..

Paul

Steve Christensen wrote:
> This is a code review request for the update of the SFWamake packages to 
> version 1.10.1.
> 
> The webrev is at
> 
> http://companion.sunfreeware.com/downloads/automakewebrev/
> 
> Details:
> 
> 1.  Updated source file.
> 2.  Changed version numbers where needed.
> 3.  Updated Copyright date where needed.
> 4.  Removed SCCS ids.
> 5.  Changed 1.8 to 1.10 in Targetdirs, install-sfw, and prototype_com where 
> needed.
> 
> This produces a working package and automake system.

1. src/pkgdefs/SFWamake/prototype_com
    You haven't removed the sccs #ident line.
    Copyright year needs changing


-- 
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Computer Products

Reply via email to