Steve, See comments below ...
Paul On Tue, 2008-07-15 at 06:52, Steve Christensen wrote: > This is a code review request for the update of the SFWmpage package to > version 2.5.6 and a complete redo of the build structure. The webrev is at > > http://companion.sunfreeware.com/downloads/mpagewebrev/ > > Details: > > 1. All of the original source files are deleted to create a structure > similar to other packages. > 2. The new source file is added. > 3. METADATA file updated. > 4. Makefile.sfw completely redone. > 5. install-sfw file created. > 6. The mpage source has no configure file, so in order to set up the > parameters for > the build to match previous builds, a patch to the mpage Makefile was > created. > 7. Copyrights updated where needed. > 8. SCCS ids removed where needed. > 9. One new encoding file added to prototype_com. > 10. Version numbers updated where needed. > 11. Web site updated in METADATA and pkginfo.tmpl. > 12. Targetdirs file updated to include the /opt/sfw/lib/mpage directory. > > This builds cleanly in a nightly in NV87 and produces a working mpage package. === Start of Comments === 1. src/cmd/mpage/install-sfw On line .. "40 _install E mpage ${PREFIX}/bin/mpage 555" you could have used just ${BINDIR}/mpage. 2. Every thing else looks okay me === End of Comments =====
