--- Steve Christensen <sunfreeware at gmail.com> wrote: > I have redone this update along the lines of Paul's > suggestion. The > new webrev is at > > http://companion.sunfreeware.com/downloads/afiowebrev/
This looks good to me Paul > The details are: > > 1. All afio source files have been removed. > 2. The afio 2.5 source file has been added. > 3. A METADATA has been added. > 4. The Makefile.sfw file has been modified to fit > the normal build method. > 5. A patch to the CFLAGS in the Makefile has been > added. > 6. An install-sfw file has been added. > 7. The pkgdefs/SFWafio/pkginfo.tmpl file has been > updated. > 8. Copyright and version numbers updated where > needed. SCCS ids removed. > > A nightly build is clean on NV 81. > > Steve Christensen > > > > Steve, > > > > Wouldn't it be better to change the way this is > built > > so it is the same as all the other packages in the > > gate, ie. uncompress the tarball during the build > in > > a > > Makefile.sfw file (rather than have all the source > > files uncompressed in the gate). It will then be > > easier to update next time around (in another 6 > years > > time :-) ) > > > > Paul > > > > --- Steve Christensen <sunfreeware at gmail.com> > wrote: > > > > > This is a code review request for an update of > the > > > afio package to version 2.5. The webrev is at > > > > > > > > > http://companion.sunfreeware.com/downloads/afiowebrev/ > > > > > > Details: > > > > > > 1. Source code updated. > > > 2. METADATA file added. > > > 3. pkginfo.tmpl file updated. > > > > > > This builds correctly in a nightly on NV 81. > The > > > package created installs properly and > > > produces a working afio binary. > > > > > > Steve Christensen > > > -- > > > This messages posted from opensolaris.org > > > _______________________________________________ > > > companion-discuss mailing list > > > companion-discuss at opensolaris.org > > > > > > http://mail.opensolaris.org/mailman/listinfo/companion > > -discuss > > > > > > > _______________________________________________ > > companion-discuss mailing list > > companion-discuss at opensolaris.org > > > http://mail.opensolaris.org/mailman/listinfo/companion > > -discuss > -- > This messages posted from opensolaris.org > _______________________________________________ > companion-discuss mailing list > companion-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/companion-discuss >
