Steve, The stuff in the webrev looks okay to me: But shouldn't there be changes to the package's pkginfo.tmpl file, and shouldn't the webrev also show the removal of the old tarball and adding of the new one.
Paul On Tue, 2008-07-29 at 22:18, Steve Christensen wrote: > This is a code review request for the update of the SFWxterm package to > version 236. > > The webrev is at > > http://companion.sunfreeware.com/downloads/xtermwebrev/ > > This update is trivial and done just to keep the xterm version at its most > recent release level. > The only changes are the xterm source file and the version number in the > various files. > > This is primarily for use in the update of the Solaris 10 Companion. > > This builds cleanly in a nightly build with no issues and produces a working > xterm package. -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
