Paul - The webrev is updated with our suggestions.
Steve C. paulcun at talk21.com wrote: > Steve, > > Again mainly looks okay to me. Minor comments ... > > in src/cmd/Makefile, the copyright/date message needs > changing + sccs ident line can be removed. > > Paul > > --- Steve Christensen <sunfreeware at gmail.com> wrote: > >> This is a code review request for the removal of the >> SFWnmap package from the Companion CD. >> >> The SUNWnmap package now exists in the SFW >> consolidation and so nmap should be removed. >> The webrev is at >> >> > http://companion.sunfreeware.com/downloads/nmapwebrev/ >> the files related to the nmap package are removed or >> modified. >> >> A nightly build is clean, no nmap package is >> created, and since no other Companion package >> depends on SFWnmap, no other package is affected. >> >> Steve Christensen >> -- >> This messages posted from opensolaris.org >> _______________________________________________ >> companion-discuss mailing list >> companion-discuss at opensolaris.org >> > http://mail.opensolaris.org/mailman/listinfo/companion-discuss > >
