This looks okay to me (sorry I did look at this yesterday, but then forgot to respond).
Paul Steve Christensen wrote: > This is a code review request for a change to the xmms Makefile.sfw file. > > The webrev is at > > http://companion.sunfreeware.com/downloads/xmmswebrev/ > > The old lines in Makefile.sfw > > GLIBS = $(if $($(MACH),i386),-L/usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3 > -lgcc,-L/usr/sfw/lib/gcc/sparc-sun-solaris2.11/3.4.3 -lgcc) > > LIBS="${GLIBS}" \ > > are no longer useful or needed in Nevada and should be removed. > > A nightly build works with no problems and produces a valid SFWxmms package > and a working xmms program after a test installation of the package. > > A METADATA file was also added. > > Steve Christensen > -- > This messages posted from opensolaris.org > _______________________________________________ > companion-discuss mailing list > companion-discuss at opensolaris.org > http://opensolaris.org/mailman/listinfo/companion-discuss >
