it looks good
paul
Steve Christensen wrote:
> Yes, you are right. I have replaced the .gz source with .bz2 and
> changed the Makefile.sfw to account for this. The new build works
> normally. The webrev is updated.
>
> Thanks,
>
> Steve C.
>
>
> Paul Cunningham wrote:
>
>> Again this looks okay to me. Minor comment, why have you used the gz
>> source archive file rather than the bz2 version (bz2 is probably
>> smaller)?
>>
>> Paul
>>
>> Steve Christensen wrote:
>>
>>> This is a code review request for an update of the SFWcurl (curl)
>>> package to version 7.16.3.
>>> A minor patch to the vorbis-tools source was also needed due to its
>>> dependency on curl.
>>>
>>> The webrev is at
>>>
>>> http://companion.sunfreeware.com/downloads/curlwebrev/
>>>
>>> The changes are:
>>>
>>> 1. Update of source and version numbers.
>>> 2. Update of copyrights and removal of sccs ids.
>>> 3. Re-versioning of libcurl files.
>>> 4. Addition of curlver.h to /opt/sfw/include/curl
>>> 5. Update of man pages
>>> 6. Addition of a METADATA file for curl
>>> 7. With the update of curl, a known patch to vorbis-tools is required.
>>>
>>> This code builds cleanly in a nightly build on NV 62 and the package
>>> installs properly creating a working curl executable.
>>>
>>> Steve Christensen
>>> --
>>> This messages posted from opensolaris.org
>>> _______________________________________________
>>> companion-discuss mailing list
>>> companion-discuss at opensolaris.org
>>> http://opensolaris.org/mailman/listinfo/companion-discuss
>>>
>>
>
