This looks okay to me. Very very minor comment, in snort/Makefile.sfw maybe the lines 49->53 should be aligned (to the CC line).
Paul Steve Christensen wrote: > This is a code review request for the update of the SFWsnort (snort) packages > to version 2.7.0. > > The webrev is at > > http://companion.sunfreeware.com/downloads/snortwebrev/ > > The details are: > > 1. Update of source code to version 2.7.0. > 2. Use of .bz2 compression instead of .gz in source and in Makefile.sfw. > 3. Update of METADATA file. > 4. Addition of two new snort directories to Targetdirs. > 5. Update of copyrights and removal of sccs ids. > 6. It was pointed out by Mike Sullivan that some library files created in > the previous snort > build were not being put into their proper directories. A fix suggested > by him to > Makefile.sfw corrects this. > 7. These library files are added to the install-sfw and prototype_com files. > 8. Update of version numbers in Makefile.sfw, install-sfw, and pkginfo.tmpl. > > This builds properly in a nightly run on NV 62. > > Steve Christensen > -- > This messages posted from opensolaris.org > _______________________________________________ > companion-discuss mailing list > companion-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/companion-discuss >
