This looks okay to me, just a couple of minor comments .....
Paul
=== COMMENTS ========
1. src/cmd/mysql-connector-java/Makefile.sfw
does the comment above your modification need changing ?
2. Both files
Does the copyright year need changing?
=== END COMMENTS ====
Steve Christensen wrote:
> This is a request for a code review of a minor fix to a Java related build
> problem in the
> Companion CD.
>
> When using Nevada 50+, java 1.6 is installed and this is incompatible with the
> mysql-connector-java build. Until this issue is fixed, JAVA_ROOT is set
> to /usr/jdk/instances/jdk1.5.0 so that java 1.5 is used instead.
>
> The webrev for this is at
>
> http://companion.sunfreeware.com/downloads/javawebrev/
>
> A nightly build was done using Nevada 56 with the latest onbld and SunStudio
> 11 packages
> installed and with revision 95 of the companion svn repository. The nightly
> completed with no build or protocmp errors.
>
> Steve Christensen
> --
> This messages posted from opensolaris.org
> _______________________________________________
> companion-discuss mailing list
> companion-discuss at opensolaris.org
> http://opensolaris.org/mailman/listinfo/companion-discuss
>
