Paul - > > > Steve Christensen wrote: > > > > Here is the reason for the sed vs. gsed in > /opt/sfw/bin. > > Being as no one else has said anything, then the > change of name is okay > with me.
OK, thanks. > > > > > Sed 4.1.5 will not build with /usr/bin/sed, it > needs the > > GNU version of sed, called sed, not gsed, in its > PATH, in this case in > > /opt/sfw/bin. If you just put gsed in > /opt/sfw/bin, the configure > > will not use it. > > Just out of interest does the build (configure/make) > of this allow you > to specify where the sed it can use is, eg. something > like > 'SED=/opt/sfw/bin/gsed', and use it? I tried this at first in fact and it did not work. I just tried it again just to be sure and it still does not work. So, this is not an option. Again, configure could be patched, but that is more of a pain I think. > > > There are two choices. Either patch the configure > > to make it also look for gsed, or much more easily, > put GNU sed, as sed, > > in /opt/sfw/bin. So, I have removed the gsed > creating part from the > > Makefile.sfw and made sure a version of GNU sed is > in /opt/sfw/bin. This > > works and if a package for sed 4.1.5 is installed > in the future, sed > > should build with non of these issues. > > > > I have modified the install-sfw to copy sed to gsed > also in > > /opt/sfw/bin. Users can keep both sed and gsed > there if they like or > > remove one or the other. > > Might have been better as a link (but it doesn't > really matter). I wanted to give the end user a way of easily being able to just delete sed or gsed rather than fiddle with which one is a link if they don't want one or the other. But, sed at least must be there for the build to work. > > > > > I have fixed the (c) issues you mention also. > > > > The new webrev is up at > > > > > http://companion.sunfreeware.com/downloads/sedwebrev/ > > looks okay to me Thanks - barring further issues, I will submit the RTI for this. > Paul > > > > > Paul Cunningham wrote: > > > >> Steve, > >> > >> Initial comment ... > >> > >> why have you removed the 'g' prefix from the > installed file name, > >> ie. /opt/sfw/bin/gsed has become > /opt/sfw/bin/sed ? > >> As a minimum shouldn't it have a link so the old > binary name is still > >> there ? gsed -> sed > >> > >> Paul > >> > >> Steve Christensen wrote: > >> > >>> This is a request for a code review for the > update of the GNU sed > >>> package from version 3.02 to latest version > 4.1.5. > >>> > >>> The webrev is at > >>> > >>> > http://companion.sunfreeware.com/downloads/sedwebrev/ > >>> > >>> The upgrade was straightforward and builds > cleanly with no protocmp > >>> errors in a nightly build in Nevada 56 on SPARC > and x86. A version > >>> of the GNU sed program (named sed, not gsed) does > need to be in > >>> /opt/sfw/bin before a build is done or configure > will produce errors. > >>> > >>> Steve Christensen > >>> -- > >>> This messages posted from opensolaris.org > >>> _______________________________________________ > >>> companion-discuss mailing list > >>> companion-discuss at opensolaris.org > >>> > http://opensolaris.org/mailman/listinfo/companion-disc > uss > >>> > >> > > > _______________________________________________ > companion-discuss mailing list > companion-discuss at opensolaris.org > http://opensolaris.org/mailman/listinfo/companion-disc > uss > -- This messages posted from opensolaris.org
