Steve, This mainly looks okay to, just one comment ...
in src/cmd/cups/Makefile.sfw it now seems to be configured to use Sun's SLP instead of the ccd's openslp. When I original added CUPS to the ccd and set it up to use SLP it didn't work with Sun's SLP - so does it work now with it (things may have changed since 2003ish)? Paul Steve Christensen wrote: > This is a code review request for the update of the SFWcups package to > version 1.2.12. > > The webrev is at > > http://companion.sunfreeware.com/downloads/cupswebrev/ > > The is a very complicated update from the previous version. The changes are: > > 1. Update of source code to version 1.2.12. > 2. Addition of a METADATA files. > 3. Update of copyrights and removal of sccs ids. > 4. Update of version numbers in Makefile.sfw, Install-sfw, and pkginfo.tmpl. > 5. Changes in configure line in Makefile.sfw from suggestions by Norm Jacobs. > 6. Patches from Norm also included. > 7. Significant changes in install-sfw and prototype_com to take into account > many new files and removal of old ones. > 8. Fixes in Targetdirs file to take into account the addition and removal of > many directories. > > This builds cleanly with no errors in NV62. I have not tested the > functionality since I > do no printing from my Solaris machines, but I am open to suggestions. > > Steve Christensen > -- > This messages posted from opensolaris.org > _______________________________________________ > companion-discuss mailing list > companion-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/companion-discuss > > -- ___________________________________________________________ Paul Cunningham Email: paulcun at talk21.com Software Engineer Tel: 01462 685974 Letchworth Garden City Hertfordshire SG6 4LH
