Eric, That looks good to me.
Should you have changed the Sun Copyright date lines in all the file to 2006 (I don't know what the policy is there though)? FYI, using PUFA to generate the files (see the Makefile.sfw) is a lot quicker, and less error prone, once you know how to use it. Paul Eric Boutilier wrote: > Per the CCD contribution process[1], this is a code review > request for my upgrade of libpcap on the Companion CD. > Please send comments to this list (companion-discuss). > > The changes consist of changing the version number in the > pkginfo.tmpl files (binary and source), install-sfw, and > Makefile.sfw; and updating the contents of DISTFILES, > EXFILES, DISTDIRS, and the source prototype_com file to > reflect files that were added/deleted upstream. (The binary > prototype_com file did not change.) > > The webrev is here: > http://companion.sunfreeware.com/downloads/libpcapwebrev/ > > The source was acquired from here: > http://www.tcpdump.org/release/libpcap-0.9.4.tar.gz > > Eric > > 1: http://www.opensolaris.org/os/project/companion/contributors/ > _______________________________________________ > companion-discuss mailing list > companion-discuss at opensolaris.org > http://opensolaris.org/mailman/listinfo/companion-discuss >
