These changes look okay to me

Paul

Steve Christensen wrote:
> This is a request for a code review of some minor fixes to vorbis-tools 
> related files.
> These changes were discovered during a full pkgadd of all of the companion cd
> packages.
> 
> The webrev for this is at
> 
> http://companion.sunfreeware.com/downloads/vorbiswebrev/
> 
> The install-sfw file in the vorbis-tools directory contained lines that 
> changed
> the libvorbis.la related files.  Since the move of ogg and vorbis to 
> /usr/lib, these
> lines are no longer needed and were removed.
> 
> The depend files for xmms, xmcd, and vorbt contained references to the 
> SFWoggl 
> package which no longer exists and so needs to be removed.  Finally, the 
> vorbis-tools
> depend file now depends on SFWao and SFWcurl and not SFWoggl and this was
> changed.
> 
> There is also some discussion of whether vorbis-tools is still needed in the 
> companion
> since no package depends on it and vorbis has been moved.  Should we just get 
> rid of
> it?
> 
> Thanks,
> 
> Steve Christensen
> --
> This messages posted from opensolaris.org
> _______________________________________________
> companion-discuss mailing list
> companion-discuss at opensolaris.org
> http://opensolaris.org/mailman/listinfo/companion-discuss
> 

Reply via email to