Paul Cunningham wrote: > > Shinsuke Sugaya wrote: >> Thank you for reviewing it! >> I updated it and put webrev to: >> >> http://cr.grommit.com/~shinsuke/cleanup/ >> > > this looks okay to me, just a few very minor comments ...
Thank you for the comment. Updated: http://cr.grommit.com/~shinsuke/cleanup/ > Paul > > ===== Start comments =================================== > > 1. The copyright year should probably be changed in the changed > files Fixed. > 2. Some of the changed files do not have the CDDL HEADER block > (prototype_i386.tmpl, etc) Fixed. > 3. cmd/ruby/Makefile.sfw > Do you really need the "--mandir=/opt/sfw/man" on the configure > line Yes. The default directory was /opt/sfw/share/man. > 4. Shouldn't pkgdefs/SFWruby/prototype_sparc have changed (its > not in your webrev) Added. Regards, shinsuke > ===== End comments ===================================== > _______________________________________________ > companion-discuss mailing list > companion-discuss at opensolaris.org > http://opensolaris.org/mailman/listinfo/companion-discuss >
