Honestly, it should be strictly greater than (>). The bug you show may be related to a different issue or in compiz in a different part of the code. They need to leave it as greater than and fix the other problems rather than leaving this as a work-around that affects other people. My guess is that someone else did a similar check in the code elsewhere or some other >= versus > check. If you think about this a bit then you will see that I'm right and they need to change this back to > and fix the code elsewhere.
On Fri, Nov 12, 2010 at 9:32 AM, Brian Starkey <600...@bugs.launchpad.net>wrote: > The > check is apparently NOT fine for Intel graphics. I haven't tried > compiling your fix myself yet (going to try this weekend, never built a > module before :-/), but Bug #428769 reports that when > is used, you get a > blank screen (with possibly one visible column of pixels). > Intel graphics with 2048 wide screens is presumably becoming a very common > setup, and I don't understand why Compiz shouldn't work on it. > > -- > Compiz fails to load when screen width == maxTextureSize > https://bugs.launchpad.net/bugs/600867 > You received this bug notification because you are a direct subscriber > of the bug. > > Status in “compiz” package in Ubuntu: New > > Bug description: > Binary package hint: compiz > > in the compiz-0.8.4/debian/patches/060_move_checks_to_compiz.patch file > there is an addition in the src/texture.c file that compares the width or > height to the maxTextureSize. The code is checking if it is '>=' where it > should only check if it is '>'. I have fixed my own code and compiz works > with this fix. This is a debian patch and should be fixed properly. My > maxTextureSize is 2048 and my screen resolution is 2048 x 1536. > > Thanks! > > ProblemType: Bug > DistroRelease: Ubuntu 10.04 > Package: compiz 1:0.8.4-0ubuntu15.1 > ProcVersionSignature: Ubuntu 2.6.32-23.37-generic 2.6.32.15+drm33.5 > Uname: Linux 2.6.32-23-generic i686 > Architecture: i386 > CompizPlugins: [shift,wobbly] > Date: Thu Jul 1 20:39:12 2010 > EcryptfsInUse: Yes > InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release i386 (20100429) > Lsusb: > Bus 004 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub > Bus 003 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub > Bus 002 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub > Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub > MachineType: IBM 183223U > PackageArchitecture: all > PccardctlIdent: > Socket 0: > no product info available > Socket 1: > no product info available > PccardctlStatus: > Socket 0: > no card > Socket 1: > no card > PciDisplay: 01:00.0 VGA compatible controller [0300]: ATI Technologies Inc > RV350 [Mobility Radeon 9600 M10] [1002:4e50] > ProcCmdLine: BOOT_IMAGE=/vmlinuz-2.6.32-23-generic > root=UUID=b527d1c0-1bd9-427d-a341-67dbb2dec2ed ro quiet splash > ProcEnviron: > PATH=(custom, user) > LANG=en_US.UTF-8 > SHELL=/bin/bash > RelatedPackageVersions: > xserver-xorg 1:7.5+5ubuntu1 > libgl1-mesa-glx 7.7.1-1ubuntu3 > libdrm2 2.4.18-1ubuntu3 > xserver-xorg-video-intel N/A > xserver-xorg-video-ati 1:6.13.0-1ubuntu5 > SourcePackage: compiz > XorgConf: Error: [Errno 2] No such file or directory: '/etc/X11/xorg.conf' > dmi.bios.date: 06/02/2006 > dmi.bios.vendor: IBM > dmi.bios.version: 1RETDPWW (3.21 ) > dmi.board.name: 183223U > dmi.board.vendor: IBM > dmi.board.version: Not Available > dmi.chassis.asset.tag: No Asset Information > dmi.chassis.type: 10 > dmi.chassis.vendor: IBM > dmi.chassis.version: Not Available > dmi.modalias: > dmi:bvnIBM:bvr1RETDPWW(3.21):bd06/02/2006:svnIBM:pn183223U:pvrThinkPadR50p:rvnIBM:rn183223U:rvrNotAvailable:cvnIBM:ct10:cvrNotAvailable: > dmi.product.name: 183223U > dmi.product.version: ThinkPad R50p > dmi.sys.vendor: IBM > system: distro = Ubuntu, architecture = i686, kernel = 2.6.32-23-generic > > To unsubscribe from this bug, go to: > https://bugs.launchpad.net/ubuntu/+source/compiz/+bug/600867/+subscribe > -- ======================================================= "The philosophy of gun control: Teenagers are roaring through town at 90 MPH, where the speed limit is 25. Your solution is to lower the speed limit to 20." - Sam Cohen, inventor of the Neutron Bomb "We maintain [privately-owned] arms largely because we seek to prevent violence. Those that wish to disarm us do so that they may perpetrate it with impunity." - R. Murray "Men cannot be governed and remain men. Domesticate the wolf and he changes both physically and mentally. His muzzle shrinks, his teeth diminish, he loses size, speed, and strength, He grows spots. His ears flop. His brain withers. He becomes a dog. Men are on the verge of becoming dogs -- the changes are underway already -- unless we do something to stop it." The Ceo Lia Wheeler, Phoebus Krumm, forthcoming "No man ever believes that the Bible means what it says; he is always convinced that it says what he means." George Bernard Shaw -- Compiz fails to load when screen width == maxTextureSize https://bugs.launchpad.net/bugs/600867 You received this bug notification because you are a member of compiz packagers, which is subscribed to compiz in ubuntu. _______________________________________________ Mailing list: https://launchpad.net/~compiz Post to : compiz@lists.launchpad.net Unsubscribe : https://launchpad.net/~compiz More help : https://help.launchpad.net/ListHelp
