Hi Alex! On 12/28/2007 10:35 AM Alexandru Stanoi wrote: > Tobias Schlitt wrote:
>> Second I added a design draft for enhancement #010913 "Complex data >> types (e.g. DateTime) for PersistentObject" [1] right before christmas >> and already started implementing it (as the main design was already >> fixed during the last summer conference and noted in the issue). Please >> take a look at PersistentObject/design/design-1.4.txt (last section) and >> state any comments here. > It looks ok to me. One question I have is how would you handle complex > conversions, for example currency conversions where you have to keep the > currency and date of exchange in the database? Are more arguments needed > for fromDatabase() and toDatabase()? This sounds like a differnent problem to me, which regards "combined properties". We currently only support a 1-column <-> 1-property mapping, so there is only 1 value to submit to the conversion. AFAIR "combined properties" is still an open discussion point where Fred was working on and he had some doubts that we can realize it properly. I'll re-check this. >> Beside this request for review, I'd like to discuss a naming issue with >> you. So far I named the interface for data type conversions >> "ezcPersistentObjectPropertyConversion", because the classes >> implementing it will perform a conversion. By now I think this name >> sounds kinda strange and should actually be >> "ezcPersistentObjectPropertyConverter" instead. What do you think? > I like the first name better, but for interfaces we are using names > similar to the second one (eg. ezcConfigurationReader, ezcFeedParser, > ezcDocumentConverter, etc). Yeah, I see it the same way. For consistency we should rename all occurances of "conversion" to "converter". Votes please: [ ] +1 (yes, rename it to "converter") [ ] 0 (whatever) [ ] -1 (no, "conversion" is better, keep it that way) Beside that, I wonder if ezcPersistentObjectPropertyConverter (and as it's implementation ezcPersistentObjectPropertyDateTimeConverter) aren't a bit toooo long names. Maybe we can reduce that to something like ezcPersistentPropertyConverter? Regards, Toby -- Mit freundlichen Grüßen / Med vennlig hilsen / With kind regards Tobias Schlitt (GPG: 0xC462BC14) eZ Components Developer [EMAIL PROTECTED] | eZ Systems AS | ez.no -- Components mailing list [email protected] http://lists.ez.no/mailman/listinfo/components
