-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Tobias Schlitt wrote:
> Hi Fred,
>
> btw. nice to see you being so active here. :)
>
> On 02/04/2009 05:08 PM Frederik Holljen wrote:
>> On 04/02/2009, Jakob Westhoff <[email protected]> wrote:
>>> >> $p = new ezcSystemProcess( 'foobar' );
>>> >> $p->workingDirectory( 'my/directory' )
>>> >> ->environment( 'MY_ENVIRONMENT_VARIABLE', '42' )
>>> >> ->environment( 'MY_OTHER_ENVIRONMENT_VARIABLE', '23' )
>>> >> ->redirect( ezcSystemProcess::STDERR, ezcSystemProcess::STDOUT )
>>> >> ->redirect( ezcSystemProcess::STDOUT, '/tmp/some/file')
>>> >> ->argument( '--first-option' )
>>> >> ->argument( '--second-option-with-a-value' )
>>> >> ->argument( $someValue )
>>> >> ->pipe( $anotherSystemProcess )
>>> >> ->execute();
>>> > To me this reads like the environment has a redirect and that the
>>> > argument has a pipe etc. How is the above an improvement over the
>>> > classical interface:
>>> > $cmd = array( 'foobar', '--first-option',
>>> > '-second-option-with-a-value', $someValue );
>>> > $p = new ezcSystemProcess();
>>> > $p->workingDirectory = 'my/directory':
>>> > $p->addEnvironment( 'MY_ENVIRONMENT_VARIABLE', '42' )
>>> > $p->addEnvironment( 'MY_OTHER_ENVIRONMENT_VARIABLE', '23' )
>>> > $p->addRedirect( ezcSystemProcess::STDERR, ezcSystemProcess::STDOUT )
>>> > $p->addRedirect( ezcSystemProcess::STDOUT, '/tmp/some/file')
>>> > $p->addPipe( $anotherSystemProcess )
>>> > $p->execute( $cmd );
>>> >
>>> > I think the latter more clearly describes the relation between the
>>> > options and the process.
>>>
>>>
>>> As far as I am concerned the fluent interface provides the way to create
>>> the command both ways. As you are not forced to use it, but have the
>>> chance to do so.
>
>> Yes, you have created a new way to create commands. But why? If it
>> doesn't provide any benefits over a normal interface what is the
>> point? I understand that you could use the fluent interface in the old
>> fashioned way also. But providing both just adds to the complexity
>> which makes it harder for people to use.
>
> I like the idea quite much to create a command as you would to it on the
> shell. With a fluent interface you always have the "problem" that you
> can do it both ways. At least, using the fluentness saves you some writing.
>
>>> Moreover it would be more consistent with the database
>>> abstraction component.
>
>> I don't see why you would want to be consistent with the database
>> abstraction component. It solves a completely different problem which
>> is a lot more complex. The two components are not related in any way.
>
> The SQL abstraction allows the creation of SQL commands, while the
> SystemProcess component allows the creation of shell commands.
>
>>> Thats a problem, which may be solved using the way I described in my
>>> other response to the idea of trying to reuse the database abstraction
>>> api. (Message-ID: <[email protected]>)
>
>> I think that is to overcomplicate the solution quite drastically. Keep
>> it simple.
>
> I like the bindParam() solution here very much. It allows simple re-use
> of a once created statement with different values. This is another
> analogy to Database, where the same SQL statement can be used with
> different values.
Furthermore a correct handling of paths along platform boundaries is
needed. Therefore methods like bindPathValue or whatever it will be
called would be needed here anyway. As I stated you could always do a
$p->argument('foobar') to bind simple values as well.
best regards,
Jakob
- --
Jakob Westhoff (GPG 0xCBF7FC6A)
http://westhoffswelt.de
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iQEcBAEBAgAGBQJJicP6AAoJEE0XwzzL9/xqodQIAKoQnSyGKJw6gNbu0AR0e3E0
zWbzCziAwkXKRz9XqruCLH/wk+r05QtXxMqupSiztkNZxRDiBJVgm8tndWzxAbmR
rvKh/iAycv4afQ+92VQYZTb9vuRbX3xCG18PtooLHdZDNeIIdVoP7JcKAjgycGEh
SXuSddgomql74eNmG+vz06HGkqBgk5Tq3nqEK8HcGI+cbXN2ySsd4Fjjg0vcoBj5
J/6Fs/03HCfQE759OESzSXE9S5bLmFKlr42EtAuEYXW9UrMqpSQDdg/SThaHxS/X
5CBoNg2k1lp/MBriomBoWhoTEjV9/PmGgZE0W5Ectr9qCbfTm6MoO7u4LppizUk=
=loyo
-----END PGP SIGNATURE-----
--
Components mailing list
[email protected]
http://lists.ez.no/mailman/listinfo/components
