Oops, wrong sender mail address - trying again... Hi, it's me again - the guy from the sourceforge forum with the plan to teach the Harmonys Philips Pronto hex codes... While looking at the IR learning code, I could not help noticing that libconcord.cpp is cluttered all the same file reading ops over and over again, so I thought it might be a good idea to make a common function for all this repeating open-read-close stuff. The patch attached is compiled (LINUX) and tested by writing back dumped firmware and configuration as well as a single IR learn on my H-785 (concordance -i -v see below). Patch attached gzipped to avoid line breaks in mail text.
BTW.: I'm trying in parallel to get used to VisualStudio 9.0
Express for WinXP, and found as first that it complained
about a line in remote_z.cpp:
> int CRemoteZ_TCP::Write(uint8_t typ, uint8_t cmd, uint32_t len,
> uint8_t *data)
>....
> pkt[0] = service_type << 4 | (cmd >> 8) & 0x0F;
- stating that with (uint8_t)cmd >> 8, there will not much be left,
which sounds reasonable to me - probably something to be fixed?
Andreas
=========================== ./concordance/concordance -i -v
Concordance 0.13+CVS
Copyright 2007 Kevin Timmerman and Phil Dibowitz
This software is distributed under the GPLv3.
Requesting Identity: 100% done
Model: Logitech Harmony 785 (Corona)
Skin: 45
Firmware Version: 4.2
Firmware Type: 0
Hardware Version: 0.8
External Flash: 2 MiB - 01:49 AMD Am29LV160BB
Architecture: 8
Protocol: 8
Manufacturer: Harmony Remote 0-4.2.2
Product: Harmony Remote 0-4.2.2
IRL, ORL, FRL: 64, 64, 0
USB VID: 046D
USB PID: C110
USB Ver: 082D
Serial Number: {EEEEEEEE-EEEE-EEEE-EEEE-EEEEEEEEEEEE}
{........-....-....-....-............}
{........-....-....-....-............}
Config Flash Used: 35% (690 of 1920 KiB)
-------------------------------------------------------
libconcord.cpp.get_from_file.patch.gz
Description: GNU Zip compressed data
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
