Stephen Warren wrote:
> OK. Here's a complete version, with concordance.c integration. It works
> for all the files in harmony_usb_logs, and a file of each type that I
> got from the Website.

I applied it, but with a few changes - see the CVS list for the actual diff,
but here's the list:

- cleaned up the switch a bit
- removed the "FIXME: This should be something NOT based on filename."
- fixed a bug in the logic (my original logic, but your work made it more
apparent) where we might try and detect mode based on file when no file was
specified
- add new API win/libconcord.def
- put the defines for your function at the top of the .h and renamed them to
LC_FILE_TYPE_*

Also, please start specifying your patch description per the
SubmittingPatches documentation so I don't have to write them for you. :)

Thanks.
-- 
Phil Dibowitz                             [EMAIL PROTECTED]
Open Source software and tech docs        Insanity Palace of Metallica
http://www.phildev.net/                   http://www.ipom.com/

"Never write it in C if you can do it in 'awk';
 Never do it in 'awk' if 'sed' can handle it;
 Never use 'sed' when 'tr' can do the job;
 Never invoke 'tr' when 'cat' is sufficient;
 Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming


Attachment: signature.asc
Description: OpenPGP digital signature

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
concordance-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/concordance-devel

Reply via email to