Stephen Warren wrote:
> Here's an updated version of the USB patch that works with WinHID on
> Windows. I had to fix:
> 
> HID_WriteReport: MS compiler won't allow creation of a variable-sized
> array on the stack, so I made the code new/delete it instead.

You changed if (Write...) to an ret = Write(..); if (err), which seemed odd
to me, so I changed it back.

Everything else you did looked fine. Patch applied fine as well.

I credit you in the commit for your help. Thanks again for testing this on
EvilOS :)

I'm thrilled to have this in. When I get back next week I'll finish up the
perl and ruby bindings, commit your python bindings, and then see if I can
figure out why firmware updates on the 5x series isn't working. And I think
that's about the last of the TODO before we get 0.20 out the door.

-- 
Phil Dibowitz                             [EMAIL PROTECTED]
Open Source software and tech docs        Insanity Palace of Metallica
http://www.phildev.net/                   http://www.ipom.com/

"Never write it in C if you can do it in 'awk';
 Never do it in 'awk' if 'sed' can handle it;
 Never use 'sed' when 'tr' can do the job;
 Never invoke 'tr' when 'cat' is sufficient;
 Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming


Attachment: signature.asc
Description: OpenPGP digital signature

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel

Reply via email to