On 01/03/2013 07:59 PM, Scott Talbert wrote: > On Wed, 2 Jan 2013, Phil Dibowitz wrote: > >>>>>> Unfortunately, no it cannot. It needs to be able to store/act on that >>>>>> information, and it can't do that without its pointer. >>>>> >>>>> Did you have any further thoughts on this? I suppose we could just add >>>>> another pointer argument to the callback? >>>>> >>>>> Also, any comments on any of my other patches? :-) >>>> >>>> Yeah, I think we should just add another callback. It sucks, but I think >>>> it's >>>> the cleanest solution. >>> >>> Add another callback? You mean like add a separate callback function, but >>> just for announcing the stages? >> >> No, I meant another argument, sorry. > > As in the attached? > > Comments?
- cb(LC_CB_STAGE_RESET, 0, 0, 2, LC_CB_COUNTER_TYPE_STEPS, cb_arg); + cb(LC_CB_STAGE_RESET, 0, 0, 2, LC_CB_COUNTER_TYPE_STEPS, + cb_arg, NULL); Why the line-wrap here? cb_arg fits in under 80 chars. And same for all the other places you did that. Also, isn't _report_number_of_stages() no longer used? Does it still need to be there? Other than that, I think this looks great. I'd like to take one more look at it when it's not super late but I think other than the two minor things above we're good to go. Thanks! -- Phil Dibowitz p...@ipom.com Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_123012
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
