On 01/06/2013 11:29 AM, Scott Talbert wrote: > On Sun, 6 Jan 2013, Phil Dibowitz wrote: > >> So this all looks fine but this: >> >> - reset_remote(cb, cb_arg); >> + if ((err = reset_remote(cb, cb_arg))) >> + return err; >> >> I think we did this because some remotes don't reset right and we didn't want >> to return a failure because of it... we just try to reset them and if they >> reset great and if not we set the time and move on. >> >> Sadly, there's no comment, but I seem to recall that being the case... was >> there a reason you changed this other than it seeming more correct? > > I originally changed it to make it more consistent (we were checking the > return value from reset_remote() in update_configuration() but not in > update_firmware()). But subsequent to that, while investigating an issue > with a congruity user, I ran into the very issue you are describing - > where the reset command works, but we get a bad return from the > HID_WriteReport(). I was working on a patch to reset_remote where it > would ignore the specific error encountered in that case, but I haven't > yet been able to get feedback from the user on whether it works or not. > But I think it would be better solution to ignore the error inside of > reset_remote, rather than have it bubble up the higher layers. Do you > happen to have one of the remote models with the problematic reset (and > could test my patch)?
I don't have one of them (or rather, I don't think I do and I don't remember what remotes they are). I agree with you in theory, but we shouldn't cause a regression in this patch... -- Phil Dibowitz p...@ipom.com Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122412
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
