On 03/29/2013 08:47 PM, Scott Talbert wrote: > On Fri, 29 Mar 2013, Phil Dibowitz wrote: > >> Agreed. You keep finding more things to support though! I was going to make >> the cut-off only zwave stuff, but you got far enough on the MH stuff I didn't >> want to hold you up. Lets call feature freeze. Lets get your open patches in >> (that's only MH support, right?), and say no more features should be added to >> said patch, only review-fixes and bug-fixes and lets get this knocked out. > > OK, v7 of the 300/MH patch uploaded to SF tracker. I think this addresses > the latest round of comments: > - Fixed for loop formatting > - Factored out common IR code > - Expanded comment for SetTime > - Addressed merge conflicts with get_stages() patch > - Pulled out MH config dump work (for now)
I considered asking of we should replace _update_configuration_mh since it's
identical to _update_configuration_zwave()... but since they're just a single
function call away, I think the abstraction is cleaner.
Only two minor comments before I merge:
+void debug_print_packet(uint8_t* p)
+{
+ debug("%02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x " \
+ "%02x %02x %02x %02x",
+ p[0], p[1], p[2], p[3], p[4], p[5], p[6], p[7], p[8], p[9],
+ p[10], p[11], p[12], p[13], p[14], p[15]);
+}
Do we perhaps want to make this a #define? I realize that debug() is a #define
that gets compiled out in normal compile and so this becomes an empty
function, which I really hope GCC compiles out, but it may be more clear
what's going on. I don't feel that strongly.
+ /* reset the sequence number to 0 */
+ if ((err = HID_WriteReport(msg_six))) {
+ debug("Failed to write to remote");
+ return LC_ERROR_WRITE;
+ }
Is that really what msg_six does, or is that an errant comment?
--
Phil Dibowitz p...@ipom.com
Open Source software and tech docs Insanity Palace of Metallica
http://www.phildev.net/ http://www.ipom.com/
"Be who you are and say what you feel, because those who mind don't matter
and those who matter don't mind."
- Dr. Seuss
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
